Skip to content

Configure Rubocop version via CircleCI configuration #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
damien opened this issue Feb 17, 2017 · 2 comments
Closed

Configure Rubocop version via CircleCI configuration #92

damien opened this issue Feb 17, 2017 · 2 comments

Comments

@damien
Copy link

damien commented Feb 17, 2017

Hey all,

First off, thanks for the awesome service! Super handy for keeping me and my teammates honest about our code quality.

That being said, it'd be great if we could specify which version of Rubocop this engine uses. My team is running a number of Rubocop-enabled projects with varying level of activity. Some of them are still on Rubocop versions as early as Rubocop v0.3x Allowing people to specify the version of Rubocop their project uses should help them avoid builds breaking due to upstream changes in this engine.

Thoughts? Comments? Let me know! I'd be more than happy to contribute to this project if the maintainers would be receptive to this change.

@damien
Copy link
Author

damien commented Feb 17, 2017

A thought on a potential implementation: Have this engine scan the ruby project in question for a Gemfile. If one is present and includes Rubocop, use the bundled version of rubocop, otherwise default to the latest, stable version of Rubocop.

@maxjacobson
Copy link
Contributor

Hi there. Depending which version of RuboCop you're using outside of Code Climate, we may already support it via engine channels. We currently offer these channels:

  • rubocop-0-42
  • rubocop-0-46
  • rubocop-0-48
  • rubocop-0-49

And we're planning to add a rubocop-0-50 soon (see tracking issue)

Long-term we may do something more automatic than this, but for the time being, please pick the channel that you prefer and feel free to let us know when we're missing support for things that you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants