Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for rubocop-0.51 #109

Closed
deivid-rodriguez opened this issue Oct 19, 2017 · 9 comments
Closed

Add support for rubocop-0.51 #109

deivid-rodriguez opened this issue Oct 19, 2017 · 9 comments
Assignees
@pointlessone @maxjacobson

Comments

@deivid-rodriguez
Copy link

Rubocop 0.51 has been released. It'd be great to get support in the official engine, via a channel, or even by fixing #93 :)

Thanks a lot!
@maxjacobson
Copy link
Contributor

Thanks for the head's up @deivid-rodriguez! I'm going to get this into our product backlog today.

@dbusanello
Copy link

Hello @maxjacobson

Is this issue fixed by #110?

@maxjacobson
Copy link
Contributor

Hi @dbusanello --

It means it's close. That work created the channel, but we still need to deploy it to codeclimate.com and the CLI.

@pointlessone, will you please update us on this issue once that's completed?

@pointlessone pointlessone self-assigned this Oct 31, 2017
@pointlessone pointlessone mentioned this issue Oct 31, 2017
Merged
@matheuslc
Copy link

Is this issue fixed? Are 0.51 channel deployed to CC already?

@maxjacobson
Copy link
Contributor

Yep, apologies for not updating this issue, but this went out to codeclimate.com and the CLI 9 days ago.

Just specify the rubocop-0-51 channel (https://docs.codeclimate.com/docs/engine-channels)

@eebs
Copy link

eebs commented Nov 9, 2017

Hi @maxjacobson, I'm not sure it did, when I run codeclimate analyze locally, I get the following error:

error: (CC::Analyzer::Container::ImageRequired) Unable to find an image for rubocop:rubocop-0-51. Available channels: ["stable", "cache-support", "rubocop-0-42", "rubocop-0-46", "rubocop-0-48", "rubocop-0-49", "rubocop-0-50"]

I'm using 0.68.0 of the CLI, and brew update && brew upgrade codeclimate says I'm up to date.

I don't see a new release of the CLI that includes this fix either.

@maxjacobson
Copy link
Contributor

Yep, good point. Looks like we didn't cut a new CLI release after adding this channel. Standby, I'll do that now.

@maxjacobson
Copy link
Contributor

Fresh off the presses: https://github.com/codeclimate/codeclimate/releases/tag/v0.69.0

@eebs
Copy link

eebs commented Nov 9, 2017

Thanks a ton!

@koic koic mentioned this issue Nov 10, 2017
Merged
koic added a commit to koic/rails that referenced this issue Nov 10, 2017
@koic
Bump RuboCop to 0.51.0
8c5115f 
## Summary

RuboCop 0.51.0 was released.
https://github.com/bbatsov/rubocop/releases/tag/v0.51.0

And rubocop-0-51 channel is available in Code Climate.
codeclimate/codeclimate-rubocop#109

This PR will bump RuboCop to 0.51.0 and fixes the following new
offenses.

```console
% bundle exec rubocop
Inspecting 2358 files

(snip)

Offenses:

actionpack/lib/action_controller/metal/http_authentication.rb:251:59: C:
Prefer double-quoted strings unless you need single quotes to avoid
extra backslashes for escaping.
          [key.strip, value.to_s.gsub(/^"|"$/, "").delete('\'')]
                                                          ^^^^
activesupport/test/core_ext/load_error_test.rb:8:39: C: Prefer
double-quoted strings unless you need single quotes to avoid extra
backslashes for escaping.
    assert_raise(LoadError) { require 'no_this_file_don\'t_exist' }
                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^

2358 files inspected, 2 offenses detected
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pointlessone pointlessone

@maxjacobson maxjacobson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pointlessone @eebs @maxjacobson @dbusanello @deivid-rodriguez @matheuslc