Bump dependencies (#87)

* Bump Ruby to 2.3.3

* Bump Rubocop and other gems

* Stop creating blank files

* Fix code style

Author: pointlessone

.ruby-version

@@ -1 +1 @@
-2.2.2
+2.3.3

Dockerfile

@@ -1,12 +1,12 @@
-FROM codeclimate/alpine-ruby:b38
+FROM ruby:2.3-alpine
 
 WORKDIR /usr/src/app
 COPY Gemfile /usr/src/app/
 COPY Gemfile.lock /usr/src/app/
 
-RUN apk --update add ruby ruby-dev ruby-bundler build-base git && \
+RUN gem install bundler && \
     bundle install -j 4 && \
-    apk del build-base && rm -fr /usr/share/ri
+    rm -fr /usr/share/ri
 
 RUN adduser -u 9000 -D app
 COPY . /usr/src/app
@@ -16,6 +16,5 @@ USER app
 
 VOLUME /code
 WORKDIR /code
-ENV GEM_PATH /code/vendor/bundle/ruby/2.2.0
 
 CMD ["/usr/src/app/bin/codeclimate-rubocop"]

Gemfile

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gem "activesupport", require: false
-gem "rubocop", "~> 0.45.0", require: false
+gem "parser", "~> 2.3.3.1"
+gem "pry", require: false
+gem "rubocop", "~> 0.45", require: false
 gem "rubocop-migrations", require: false
 gem "rubocop-rspec", require: false
 gem "safe_yaml"
-gem "pry", require: false
-gem "parser", "~> 2.3.1.1"
 
 group :test do
   gem "rake"

Gemfile.lock

@@ -1,72 +1,71 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (4.2.5.1)
+    activesupport (5.0.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
-      json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
-      thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
     ast (2.3.0)
-    coderay (1.1.0)
+    coderay (1.1.1)
+    concurrent-ruby (1.0.3)
     diff-lcs (1.2.5)
     i18n (0.7.0)
-    json (1.8.3)
     method_source (0.8.2)
-    minitest (5.8.4)
-    parser (2.3.1.4)
+    minitest (5.10.1)
+    parser (2.3.3.1)
       ast (~> 2.2)
     powerpack (0.1.1)
-    pry (0.10.3)
+    pry (0.10.4)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
     rainbow (2.1.0)
-    rake (10.5.0)
-    rspec (3.3.0)
-      rspec-core (~> 3.3.0)
-      rspec-expectations (~> 3.3.0)
-      rspec-mocks (~> 3.3.0)
-    rspec-core (3.3.1)
-      rspec-support (~> 3.3.0)
-    rspec-expectations (3.3.0)
+    rake (12.0.0)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.4)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-mocks (3.3.1)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-support (3.3.0)
-    rubocop (0.45.0)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
+    rubocop (0.46.0)
       parser (>= 2.3.1.1, < 3.0)
       powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
     rubocop-migrations (0.1.2)
       rubocop (~> 0.41)
-    rubocop-rspec (1.5.0)
-      rubocop (>= 0.40.0)
+    rubocop-rspec (1.8.0)
+      rubocop (>= 0.42.0)
     ruby-progressbar (1.8.1)
     safe_yaml (1.0.4)
     slop (3.6.0)
     thread_safe (0.3.5)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
-    unicode-display_width (1.1.1)
+    unicode-display_width (1.1.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   activesupport
-  parser (~> 2.3.1.1)
+  parser (~> 2.3.3.1)
   pry
   rake
   rspec
-  rubocop (~> 0.45.0)
+  rubocop (~> 0.45)
   rubocop-migrations
   rubocop-rspec
   safe_yaml
 
 BUNDLED WITH
-   1.13.3
+   1.13.6

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rspec/core/rake_task"
 
 Rake.add_rakelib "lib/tasks"

bin/codeclimate-rubocop

@@ -1,14 +1,17 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 $:.unshift(
   File.expand_path(File.join(File.dirname(__FILE__), "../lib"))
 )
 
 require 'cc/engine/rubocop'
 
-if File.exist?("/config.json")
-  engine_config = JSON.parse(File.read("/config.json"))
-else
-  engine_config = {}
-end
+engine_config =
+  if File.exist?("/config.json")
+    JSON.parse(File.read("/config.json"))
+  else
+    {}
+  end
 
 CC::Engine::Rubocop.new(Dir.pwd, engine_config, STDOUT).run

config/contents/bundler/duplicated_gem.md

@@ -0,0 +1,22 @@
+A Gem's requirements should be listed only once in a Gemfile.
+### Example:
+    # bad
+    gem 'rubocop'
+    gem 'rubocop'
+
+    # bad
+    group :development do
+      gem 'rubocop'
+    end
+
+    group :test do
+      gem 'rubocop'
+    end
+
+    # good
+    group :development, :test do
+      gem 'rubocop'
+    end
+
+    # good
+    gem 'rubocop', groups: [:development, :test]

config/contents/bundler/ordered_gems.md

@@ -0,0 +1,14 @@
+Gems in consecutive lines should be alphabetically sorted
+### Example:
+    # bad
+    gem 'rubocop'
+    gem 'rspec'
+
+    # good
+    gem 'rspec'
+    gem 'rubocop'
+
+    # good
+    gem 'rubocop'
+
+    gem 'rspec'

config/contents/lint/non_local_exit_from_iterator.md

@@ -1,7 +1,8 @@
 This cop checks for non-local exit from iterator, without return value.
 It warns only when satisfies all of these: `return` doesn't have return
 value, the block is preceded by a method chain, the block has arguments,
-and the method which receives the block is not `define_method`.
+and the method which receives the block is not `define_method`
+or `define_singleton_method`.
 
 ### Example:
 

config/contents/performance/compare_with_block.md

@@ -0,0 +1,18 @@
+This cop identifies places where `sort { |a, b| a.foo <=> b.foo }`
+can be replaced by `sort_by(&:foo)`.
+This cop also checks `max` and `min` methods.
+
+### Example:
+    # bad
+    array.sort { |a, b| a.foo <=> b.foo }
+    array.max { |a, b| a.foo <=> b.foo }
+    array.min { |a, b| a.foo <=> b.foo }
+
+    # good
+    array.sort_by(&:foo)
+    array.sort_by { |v| v.foo }
+    array.sort_by do |var|
+      var.foo
+    end
+    array.max_by(&:foo)
+    array.min_by(&:foo)

config/contents/rails/enum_uniqueness.md

@@ -0,0 +1,14 @@
+This cop looks for duplicate values in enum declarations.
+
+### Example:
+    # bad
+    enum status: { active: 0, archived: 0 }
+
+    # good
+    enum status: { active: 0, archived: 1 }
+
+    # bad
+    enum status: [:active, :archived, :active]
+
+    # good
+    enum status: [:active, :archived]

config/contents/style/empty_method.md

@@ -0,0 +1,30 @@
+This cop checks for the formatting of empty method definitions.
+By default it enforces empty method definitions to go on a single
+line (compact style), but it cah be configured to enforce the `end`
+to go on its own line (expanded style.)
+
+Note: A method definition is not considered empty if it contains
+        comments.
+
+### Example:
+
+    EnforcedStyle: compact (default)
+
+    # bad
+    def foo(bar)
+    end
+
+    # good
+    def foo(bar); end
+    def foo(bar)
+      # baz
+    end
+
+    EnforcedStyle: expanded
+
+    # bad
+    def foo(bar); end
+
+    # good
+    def foo(bar)
+    end

config/contents/style/numeric_predicate.md

@@ -1,23 +1,25 @@
-This cop checks for usage of comparison operators (`==`, `!=`,
-`>`, `<`) to test numbers as zero, nonzero, positive, or negative.
+This cop checks for usage of comparison operators (`==`,
+`>`, `<`) to test numbers as zero, positive, or negative.
 These can be replaced by their respective predicate methods.
 The cop can also be configured to do the reverse.
 
+The cop disregards `nonzero?` as it its value is truthy or falsey,
+but not `true` and `false`, and thus not always interchangeable with
+`!= 0`.
+
 ### Example:
 
     # EnforcedStyle: predicate (default)
 
     # bad
 
     foo == 0
-    0 != bar.baz
     0 > foo
     bar.baz > 0
 
     # good
 
     foo.zero?
-    bar.baz.nonzero?
     foo.negative?
     bar.baz.positive?
 
@@ -28,13 +30,11 @@ The cop can also be configured to do the reverse.
     # bad
 
     foo.zero?
-    bar.baz.nonzero?
     foo.negative?
     bar.baz.positive?
 
     # good
 
     foo == 0
-    0 != bar.baz
     0 > foo
     bar.baz > 0

config/contents/style/ternary_parentheses.md

@@ -28,4 +28,18 @@ parentheses using `EnforcedStyle`.
     # good
     foo = (bar?) ? a : b
     foo = (bar.baz) ? a : b
+    foo = (bar && baz) ? a : b
+
+### Example:
+
+    EnforcedStyle: require_parentheses_when_complex
+
+    # bad
+    foo = (bar?) ? a : b
+    foo = (bar.baz?) ? a : b
+    foo = bar && baz ? a : b
+
+    # good
+    foo = bar? ? a : b
+    foo = bar.baz ? a : b
     foo = (bar && baz) ? a : b

lib/cc/engine/category_parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module CC
   module Engine
     class CategoryParser
@@ -11,7 +13,7 @@ def category
 
       private
 
-      DEFAULT_CATEGORY = "Style".freeze
+      DEFAULT_CATEGORY = "Style"
       CATEGORIES = {
         "Lint" => "Style",
         "Lint/Eval" => "Security",

lib/cc/engine/content_resolver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/string"
 
 module CC

lib/cc/engine/file_list_resolver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module CC
   module Engine
     class FileListResolver

lib/cc/engine/fingerprint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "digest/md5"
 
 module CC