Skip to content

Add support for eslint-import-resolver-meteor #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
athyuttamre opened this issue Mar 8, 2017 · 5 comments
Closed

Add support for eslint-import-resolver-meteor #200

athyuttamre opened this issue Mar 8, 2017 · 5 comments
Assignees

Comments

@athyuttamre
Copy link

athyuttamre commented Mar 8, 2017

Support for Meteor was recently added to the eslint engine, but I forgot to mention another key component. Meteor projects often import like this:

  • import { Meteor } from 'meteor'
  • import /imports/ui/components/button/button

Typically the eslint engine fails both with the error Resolve error: unable to load resolver "meteor".. The fix is to use the eslint-import-resolver-meteor plugin, which is also recommended by Meteor's official guide.

Could we add support for this please?

@athyuttamre
Copy link
Author

I suppose this is similar to #143. Looks like the change from that issue was reverted, and support was never added again. Any chance of this working?

@dblandin
Copy link
Contributor

@athyuttamre Yep. Unfortunately adding support for the eslint-import-resolver-meteor plugin would hit the same limitations as #143. We've talked internally of blacklisting rules that rely on npm module resolution within the engine until we have a better solution.

@dblandin dblandin self-assigned this Mar 14, 2017
@gfink57
Copy link

gfink57 commented Mar 16, 2017

We have the same requirement for handling Meteor imports as @athyuttamre. On the order of 6K associated errors in our analysis runs.

@dblandin
Copy link
Contributor

Blacklisting rules that rely on npm module resolution is in the works. I'll comment again when I have an update. Thanks for your patience!

In the meantime, if the invalid issues are coming from the same checks you can disable the checks entirely by excluding them within your .codeclimate.yml file:

https://docs.codeclimate.com/v1.0/docs/disabling-individual-checks

@dblandin
Copy link
Contributor

I've opened up a new issue which will track work to ignore rules relying on npm module resolution. I'm going to go ahead and close this issue as we won't be able to support such rules at this time

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants