add tests for ShowsEffect

Author: codeBelt

Diff for: package.json

@@ -89,6 +89,7 @@
     "generate-template-files": "2.2.1",
     "gh-pages": "2.2.0",
     "husky": "4.2.3",
+    "nock": "12.0.3",
     "node-sass": "4.13.1",
     "prettier": "1.19.1",
     "pretty-quick": "2.0.1",

Diff for: src/stores/shows/ShowsEffect.spec.js

@@ -0,0 +1,72 @@
+import ShowsEffect from './ShowsEffect';
+import nock from 'nock';
+import axios from 'axios';
+import environment from 'environment';
+import ShowModel from './models/shows/ShowModel';
+import StringUtil from '../../utilities/StringUtil';
+import EpisodeModel from './models/episodes/EpisodeModel';
+import CastModel from './models/cast/CastModel';
+
+axios.defaults.adapter = require('axios/lib/adapters/http');
+
+describe('ShowsEffect', () => {
+  describe('requestShow', () => {
+    it('has a successful response', async () => {
+      const showId = '74';
+      const endpoint = environment.api.shows.replace(':showId', showId);
+      const [baseUrl, sourceUrl] = StringUtil.splitBySeparator(endpoint, '.com');
+
+      const scope = nock(baseUrl)
+        .get(sourceUrl)
+        .reply(200, { name: 'Robert' });
+
+      const actualResult = await ShowsEffect.requestShow(showId);
+
+      expect(actualResult).toBeInstanceOf(ShowModel);
+      expect(actualResult.name).toEqual('Robert');
+
+      // Assert that the expected request was made.
+      scope.done();
+    });
+  });
+
+  describe('requestEpisodes', () => {
+    it('has a successful response', async () => {
+      const showId = '74';
+      const endpoint = environment.api.episodes.replace(':showId', showId);
+      const [baseUrl, sourceUrl] = StringUtil.splitBySeparator(endpoint, '.com');
+
+      const scope = nock(baseUrl)
+        .get(sourceUrl)
+        .reply(200, [{ summary: 'Robert is cool' }]);
+
+      const actualResult = await ShowsEffect.requestEpisodes(showId);
+
+      expect(actualResult[0]).toBeInstanceOf(EpisodeModel);
+      expect(actualResult[0].summary).toEqual('Robert is cool');
+
+      // Assert that the expected request was made.
+      scope.done();
+    });
+  });
+
+  describe('requestCast', () => {
+    it('has a successful response', async () => {
+      const showId = '74';
+      const endpoint = environment.api.cast.replace(':showId', showId);
+      const [baseUrl, sourceUrl] = StringUtil.splitBySeparator(endpoint, '.com');
+
+      const scope = nock(baseUrl)
+        .get(sourceUrl)
+        .reply(200, [{ self: true }]);
+
+      const actualResult = await ShowsEffect.requestCast(showId);
+
+      expect(actualResult[0]).toBeInstanceOf(CastModel);
+      expect(actualResult[0].self).toBe(true);
+
+      // Assert that the expected request was made.
+      scope.done();
+    });
+  });
+});

Diff for: src/utilities/StringUtil.js

@@ -0,0 +1,15 @@
+export default class StringUtil {
+  /**
+   * Splits a string in half by a separator
+   *
+   * @param str string
+   * @param separator string
+   * @example
+   *    splitBySeparator('https://api.tvmaze.com/search/shows?q=Friends', '.com');
+   *
+   *    // ['https://api.tvmaze.com', '/search/shows?q=Friends']
+   */
+  static splitBySeparator = (str, separator) => {
+    return str.split(new RegExp(`(.*?${separator})`, 'g')).filter(Boolean);
+  };
+}

Diff for: yarn.lock

@@ -6672,7 +6672,7 @@ json-stable-stringify@^1.0.1:
   dependencies:
     jsonify "~0.0.0"
 
-json-stringify-safe@~5.0.1:
+json-stringify-safe@^5.0.1, json-stringify-safe@~5.0.1:
   version "5.0.1"
   resolved "https://registry.yarnpkg.com/json-stringify-safe/-/json-stringify-safe-5.0.1.tgz#1296a2d58fd45f19a0f6ce01d65701e2c735b6eb"
   integrity sha1-Epai1Y/UXxmg9s4B1lcB4sc1tus=
@@ -7464,6 +7464,16 @@ no-case@^3.0.3:
     lower-case "^2.0.1"
     tslib "^1.10.0"
 
+[email protected]:
+  version "12.0.3"
+  resolved "https://registry.yarnpkg.com/nock/-/nock-12.0.3.tgz#83f25076dbc4c9aa82b5cdf54c9604c7a778d1c9"
+  integrity sha512-QNb/j8kbFnKCiyqi9C5DD0jH/FubFGj5rt9NQFONXwQm3IPB0CULECg/eS3AU1KgZb/6SwUa4/DTRKhVxkGABw==
+  dependencies:
+    debug "^4.1.0"
+    json-stringify-safe "^5.0.1"
+    lodash "^4.17.13"
+    propagate "^2.0.0"
+
 [email protected]:
   version "0.9.0"
   resolved "https://registry.yarnpkg.com/node-forge/-/node-forge-0.9.0.tgz#d624050edbb44874adca12bb9a52ec63cb782579"
@@ -9079,6 +9089,11 @@ prop-types@^15.6.1, prop-types@^15.6.2, prop-types@^15.7.2:
     object-assign "^4.1.1"
     react-is "^16.8.1"
 
+propagate@^2.0.0:
+  version "2.0.1"
+  resolved "https://registry.yarnpkg.com/propagate/-/propagate-2.0.1.tgz#40cdedab18085c792334e64f0ac17256d38f9a45"
+  integrity sha512-vGrhOavPSTz4QVNuBNdcNXePNdNMaO1xj9yBeH1ScQPjk/rhg9sSlCXPhMkFuaNNW/syTvYqsnbIJxMBfRbbag==
+
 proxy-addr@~2.0.5:
   version "2.0.6"
   resolved "https://registry.yarnpkg.com/proxy-addr/-/proxy-addr-2.0.6.tgz#fdc2336505447d3f2f2c638ed272caf614bbb2bf"