Skip to content

Commit dcacd8a

Browse files
marksoperMark Soperfantapop
authoredJun 20, 2024··
Adding a warning to the README about the need to use a recent version of the provider for private endpoints (#218)
* Update README.md Adding a warning to the README about the need to use a recent version of the provider for private endpoints to avoid a recently discovered bug in older versions. * Update README.md * Update README.md * Update README.md * adding warning to /docs * Update private_endpoint_connection.md * Update private_endpoint_services.md * source of docs * fixed placement of warning and generated docs * updated changelog for privaet endpoint version warning --------- Co-authored-by: Mark Soper <[email protected]> Co-authored-by: Christopher Fitzner <[email protected]>
1 parent bc77c78 commit dcacd8a

6 files changed

+57
-4
lines changed
 

‎CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
11+
- Added warning about using private endpoints with old versions.
12+
1013
## Fixed
1114

1215
- Update the user_role_grants resource docs to indicate the requirement of ORG_MEMBER.

‎README.md

+8-2
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,16 @@
88

99
For information on developing `terraform-provider-cockroach` see [DEVELOPMENT.md](DEVELOPMENT.md).
1010

11-
**Note: This is a preview release, suitable only for experimental use.**
12-
1311
## Get Started
1412

13+
### _Warning_: Use of *private endpoints* requires >=v1.7.6
14+
If you intend to use this provider to provision [private endpoints](https://github.com/cockroachdb/terraform-provider-cockroach/blob/main/docs/resources/private_endpoint_connection.md):
15+
- [AWS PrivateLink](https://www.cockroachlabs.com/docs/cockroachcloud/aws-privatelink)
16+
- [GCP Private Service Connect](https://www.cockroachlabs.com/docs/cockroachcloud/connect-to-your-cluster#gcp-private-service-connect)
17+
- [Azure Private Link](https://www.cockroachlabs.com/docs/cockroachcloud/cockroachdb-dedicated-on-azure)
18+
19+
You must install/upgrade to [version 1.7.6](https://github.com/cockroachdb/terraform-provider-cockroach/releases/tag/v1.7.6) or [later](https://registry.terraform.io/providers/cockroachdb/cockroach/latest).
20+
1521
### Prerequisites
1622

1723
Before you use `terraform-provider-cockroach` you must [install Terraform](https://learn.hashicorp.com/tutorials/terraform/install-cli) and [`git`](https://git-scm.com/downloads) on your local machine.

‎docs/resources/private_endpoint_connection.md

+14
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,26 @@ page_title: "cockroach_private_endpoint_connection Resource - terraform-provider
44
subcategory: ""
55
description: |-
66
Private endpoint connections allow customer applications to connect to a CockroachDB Cloud cluster without traversing the public internet. All application-database traffic remains within the cloud-provider network.
7+
Warning: Use of private endpoints requires >=v1.7.6
8+
If you intend to use this provider to provision private endpoints https://github.com/cockroachdb/terraform-provider-cockroach/blob/main/docs/resources/private_endpoint_connection.md:
9+
- AWS PrivateLink https://www.cockroachlabs.com/docs/cockroachcloud/aws-privatelink
10+
- GCP Private Service Connect https://www.cockroachlabs.com/docs/cockroachcloud/connect-to-your-cluster#gcp-private-service-connect
11+
- Azure Private Link https://www.cockroachlabs.com/docs/cockroachcloud/cockroachdb-dedicated-on-azure
12+
You must install/upgrade to version 1.7.6 https://github.com/cockroachdb/terraform-provider-cockroach/releases/tag/v1.7.6 or later https://registry.terraform.io/providers/cockroachdb/cockroach/latest
713
---
814

915
# cockroach_private_endpoint_connection (Resource)
1016

1117
Private endpoint connections allow customer applications to connect to a CockroachDB Cloud cluster without traversing the public internet. All application-database traffic remains within the cloud-provider network.
1218

19+
### _Warning_: Use of *private endpoints* requires >=v1.7.6
20+
If you intend to use this provider to provision [private endpoints](https://github.com/cockroachdb/terraform-provider-cockroach/blob/main/docs/resources/private_endpoint_connection.md):
21+
- [AWS PrivateLink](https://www.cockroachlabs.com/docs/cockroachcloud/aws-privatelink)
22+
- [GCP Private Service Connect](https://www.cockroachlabs.com/docs/cockroachcloud/connect-to-your-cluster#gcp-private-service-connect)
23+
- [Azure Private Link](https://www.cockroachlabs.com/docs/cockroachcloud/cockroachdb-dedicated-on-azure)
24+
25+
You must install/upgrade to [version 1.7.6](https://github.com/cockroachdb/terraform-provider-cockroach/releases/tag/v1.7.6) or [later](https://registry.terraform.io/providers/cockroachdb/cockroach/latest)
26+
1327
## Example Usage
1428

1529
```terraform

‎docs/resources/private_endpoint_services.md

+14
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,25 @@ page_title: "cockroach_private_endpoint_services Resource - terraform-provider-c
44
subcategory: ""
55
description: |-
66
PrivateEndpointServices contains services that allow for private connectivity to the CockroachDB Cloud cluster.
7+
Warning: Use of private endpoints requires >=v1.7.6
8+
If you intend to use this provider to provision private endpoints https://github.com/cockroachdb/terraform-provider-cockroach/blob/main/docs/resources/private_endpoint_connection.md:
9+
- AWS PrivateLink https://www.cockroachlabs.com/docs/cockroachcloud/aws-privatelink
10+
- GCP Private Service Connect https://www.cockroachlabs.com/docs/cockroachcloud/connect-to-your-cluster#gcp-private-service-connect
11+
- Azure Private Link https://www.cockroachlabs.com/docs/cockroachcloud/cockroachdb-dedicated-on-azure
12+
You must install/upgrade to version 1.7.6 https://github.com/cockroachdb/terraform-provider-cockroach/releases/tag/v1.7.6 or later https://registry.terraform.io/providers/cockroachdb/cockroach/latest
713
---
814

915
# cockroach_private_endpoint_services (Resource)
1016

1117
PrivateEndpointServices contains services that allow for private connectivity to the CockroachDB Cloud cluster.
18+
19+
### _Warning_: Use of *private endpoints* requires >=v1.7.6
20+
If you intend to use this provider to provision [private endpoints](https://github.com/cockroachdb/terraform-provider-cockroach/blob/main/docs/resources/private_endpoint_connection.md):
21+
- [AWS PrivateLink](https://www.cockroachlabs.com/docs/cockroachcloud/aws-privatelink)
22+
- [GCP Private Service Connect](https://www.cockroachlabs.com/docs/cockroachcloud/connect-to-your-cluster#gcp-private-service-connect)
23+
- [Azure Private Link](https://www.cockroachlabs.com/docs/cockroachcloud/cockroachdb-dedicated-on-azure)
24+
25+
You must install/upgrade to [version 1.7.6](https://github.com/cockroachdb/terraform-provider-cockroach/releases/tag/v1.7.6) or [later](https://registry.terraform.io/providers/cockroachdb/cockroach/latest)
1226

1327
## Example Usage
1428

‎internal/provider/private_endpoint_connection_resource.go

+9-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,15 @@ func (r *privateEndpointConnectionResource) Schema(
4848
_ context.Context, _ resource.SchemaRequest, resp *resource.SchemaResponse,
4949
) {
5050
resp.Schema = schema.Schema{
51-
MarkdownDescription: "Private endpoint connections allow customer applications to connect to a CockroachDB Cloud cluster without traversing the public internet. All application-database traffic remains within the cloud-provider network.",
51+
MarkdownDescription: `Private endpoint connections allow customer applications to connect to a CockroachDB Cloud cluster without traversing the public internet. All application-database traffic remains within the cloud-provider network.
52+
53+
### _Warning_: Use of *private endpoints* requires >=v1.7.6
54+
If you intend to use this provider to provision [private endpoints](https://github.com/cockroachdb/terraform-provider-cockroach/blob/main/docs/resources/private_endpoint_connection.md):
55+
- [AWS PrivateLink](https://www.cockroachlabs.com/docs/cockroachcloud/aws-privatelink)
56+
- [GCP Private Service Connect](https://www.cockroachlabs.com/docs/cockroachcloud/connect-to-your-cluster#gcp-private-service-connect)
57+
- [Azure Private Link](https://www.cockroachlabs.com/docs/cockroachcloud/cockroachdb-dedicated-on-azure)
58+
59+
You must install/upgrade to [version 1.7.6](https://github.com/cockroachdb/terraform-provider-cockroach/releases/tag/v1.7.6) or [later](https://registry.terraform.io/providers/cockroachdb/cockroach/latest)`,
5260
Attributes: map[string]schema.Attribute{
5361
"id": schema.StringAttribute{
5462
Computed: true,

‎internal/provider/private_endpoint_services_resource.go

+9-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,15 @@ type privateEndpointServicesResource struct {
4343
const endpointServicesCreateTimeout = time.Hour
4444

4545
var endpointServicesSchema = schema.Schema{
46-
MarkdownDescription: "PrivateEndpointServices contains services that allow for private connectivity to the CockroachDB Cloud cluster.",
46+
MarkdownDescription: `PrivateEndpointServices contains services that allow for private connectivity to the CockroachDB Cloud cluster.
47+
48+
### _Warning_: Use of *private endpoints* requires >=v1.7.6
49+
If you intend to use this provider to provision [private endpoints](https://github.com/cockroachdb/terraform-provider-cockroach/blob/main/docs/resources/private_endpoint_connection.md):
50+
- [AWS PrivateLink](https://www.cockroachlabs.com/docs/cockroachcloud/aws-privatelink)
51+
- [GCP Private Service Connect](https://www.cockroachlabs.com/docs/cockroachcloud/connect-to-your-cluster#gcp-private-service-connect)
52+
- [Azure Private Link](https://www.cockroachlabs.com/docs/cockroachcloud/cockroachdb-dedicated-on-azure)
53+
54+
You must install/upgrade to [version 1.7.6](https://github.com/cockroachdb/terraform-provider-cockroach/releases/tag/v1.7.6) or [later](https://registry.terraform.io/providers/cockroachdb/cockroach/latest)`,
4755
Attributes: map[string]schema.Attribute{
4856
"cluster_id": schema.StringAttribute{
4957
Required: true,

0 commit comments

Comments
 (0)
Please sign in to comment.