From df506dc094166db3171371bbdc52039b156323c2 Mon Sep 17 00:00:00 2001 From: rharding6373 Date: Fri, 7 Mar 2025 19:28:43 +0000 Subject: [PATCH] changefeedccl: increase random queries generated in changefeed test This change increases the number of attempts at testing a non-trivial query by 50% and now checks that there is at least 1 non-trivial test in order to reduce flakiness. Epic: none Fixes: #142383 Release note: none --- pkg/ccl/changefeedccl/changefeed_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/ccl/changefeedccl/changefeed_test.go b/pkg/ccl/changefeedccl/changefeed_test.go index 30ce0fd2e19a..f6a3abe728d0 100644 --- a/pkg/ccl/changefeedccl/changefeed_test.go +++ b/pkg/ccl/changefeedccl/changefeed_test.go @@ -1257,7 +1257,7 @@ func TestChangefeedRandomExpressions(t *testing.T) { require.NoError(t, err) defer queryGen.Close() numNonTrivialTestRuns := 0 - n := 100 + n := 150 whereClausesChecked := make(map[string]struct{}, n) for i := 0; i < n; i++ { query := queryGen.Generate() @@ -1340,7 +1340,7 @@ func TestChangefeedRandomExpressions(t *testing.T) { } numNonTrivialTestRuns++ } - require.Greater(t, numNonTrivialTestRuns, 1) + require.Greater(t, numNonTrivialTestRuns, 0, "Expected >0 predicates to be nontrivial out of %d attempts", n) t.Logf("%d predicates checked: all had the same result in SELECT and CHANGEFEED", numNonTrivialTestRuns) }