Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemachanger: remove TODOTestTenantDisabled from SingleNodeTestClusterFactory.Run. #142814

Open
shubhamdhama opened this issue Mar 13, 2025 · 0 comments
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@shubhamdhama
Copy link
Contributor

shubhamdhama commented Mar 13, 2025

Tests count (est.): 1

We should remove TODOTestTenantDisabled to enable tenant testing for the datadriven and standard unit tests:

func (f SingleNodeTestClusterFactory) Run(
ctx context.Context, t *testing.T, fn func(_ serverutils.TestServerInterface, _ *gosql.DB),
) {
args := base.TestServerArgs{
Knobs: base.TestingKnobs{
JobsTestingKnobs: newJobsKnobs(),
SQLExecutor: &sql.ExecutorTestingKnobs{
UseTransactionalDescIDGenerator: true,
},
},
// TODO(postamar): remove this
DefaultTestTenant: base.TODOTestTenantDisabled,
}

pkg/sql/schemachanger/sctest/backup.go
  235, 40: WithSchemaChangerKnobs(knobs).Run(ctx, t, runfn)
  335, 40: WithSchemaChangerKnobs(knobs).Run(ctx, t, runfn)

pkg/sql/schemachanger/sctest/cumulative.go
  103, 41: WithSchemaChangerKnobs(knobs).Run(ctx, t, runfn)
  252, 41: WithSchemaChangerKnobs(knobs).Run(ctx, t, runfn)
  296, 6: 		}).Run(ctx, t, func(s serverutils.TestServerInterface, db *gosql.DB) {
  386, 40: WithSchemaChangerKnobs(knobs).Run(ctx, t, runfn)

pkg/sql/schemachanger/sctest/decomp.go
  43, 11: 		factory.Run(ctx, t, func(_ serverutils.TestServerInterface, db *gosql.DB) {

pkg/sql/schemachanger/sctest/end_to_end.go
  66, 10: 	factory.Run(ctx, t, func(s serverutils.TestServerInterface, db *gosql.DB) {

pkg/sql/schemachanger/sctest/framework.go
  819, 5: 	}).Run(context.Background(), t, func(_ serverutils.TestServerInterface, db *gosql.DB) {
  925, 10: 	factory.Run(ctx, t, func(s serverutils.TestServerInterface, db *gosql.DB) {

pkg/sql/schemachanger/sctest/test_server_factory.go
  74, 39: SingleNodeTestClusterFactory) Run(

Informs: #138912
Epic: CRDB-48357

Jira issue: CRDB-48534

@shubhamdhama shubhamdhama added A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

No branches or pull requests

1 participant