Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin apis: remove usages of TODOTestTenantDisabled #142805

Open
shubhamdhama opened this issue Mar 13, 2025 · 0 comments
Open

admin apis: remove usages of TODOTestTenantDisabled #142805

shubhamdhama opened this issue Mar 13, 2025 · 0 comments
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@shubhamdhama
Copy link
Contributor

shubhamdhama commented Mar 13, 2025

Tests count (est.): 3

We have identified several instances of TODOTestTenantDisabled in pkg/server/application_api/ that should be investigated and enabled to run in multi-tenant mode.

❯ rg -n TODOTestTenantDisabled -- pkg/server/storage_api/rangelog_test.go pkg/ccl/serverccl/admin_test.go | sort

pkg/ccl/serverccl/admin_test.go:123:            DefaultTestTenant: base.TODOTestTenantDisabled,
pkg/server/storage_api/rangelog_test.go:100:                    DefaultTestTenant: base.TODOTestTenantDisabled,
pkg/server/storage_api/rangelog_test.go:31:             DefaultTestTenant: base.TODOTestTenantDisabled,
❯ rg -l TODOTestTenantDisabled -- pkg/server/storage_api/rangelog_test.go pkg/ccl/serverccl/admin_test.go | sort | uniq | xargs -I {} whoownsit {} | sort

cockroachdb/obs-prs   pkg/ccl/serverccl/admin_test.go
cockroachdb/unowned   pkg/server/storage_api/rangelog_test.go

Informs: #138912
Epic: CRDB-38970

Jira issue: CRDB-48525

@shubhamdhama shubhamdhama added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multitenancy Related to multi-tenancy labels Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

No branches or pull requests

1 participant