Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: enable external-mode tenant testing for TestUnsplitRanges #142388

Open
shubhamdhama opened this issue Mar 6, 2025 · 0 comments
Open

sql: enable external-mode tenant testing for TestUnsplitRanges #142388

shubhamdhama opened this issue Mar 6, 2025 · 0 comments
Labels
A-multitenancy Related to multi-tenancy C-investigation Further steps needed to qualify. C-label will change.

Comments

@shubhamdhama
Copy link
Contributor

shubhamdhama commented Mar 6, 2025 •
edited by cockroach-jira-scripts
Loading

Related: #140446

While enabling tenant testing for TestUnsplitRanges, making it work for external-process mode isn’t trivial. I’m creating this issue and disabling the test for external-process mode. I don’t think there’s any feature gap—it’s just a matter of fixing the test.

Jira issue: CRDB-48308
@shubhamdhama shubhamdhama added A-multitenancy Related to multi-tenancy C-investigation Further steps needed to qualify. C-label will change. labels Mar 6, 2025
shubhamdhama added a commit to shubhamdhama/cockroach that referenced this issue Mar 6, 2025
@shubhamdhama
sql: enable shared-process mode tenant testing for TestUnsplitRanges

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c370cdd 
I opened issue cockroachdb#142388 to track the work for enabling external-process mode
testing, as it turned out to be a non-trivial effort.
@shubhamdhama shubhamdhama mentioned this issue Mar 6, 2025
Merged
shubhamdhama added a commit to shubhamdhama/cockroach that referenced this issue Mar 13, 2025
@shubhamdhama
sql: enable shared-process mode tenant testing for TestUnsplitRanges
bf124c9 
I opened issue cockroachdb#142388 to track the work for enabling external-process mode
testing, as it turned out to be a non-trivial effort.
shubhamdhama added a commit to shubhamdhama/cockroach that referenced this issue Mar 14, 2025
@shubhamdhama
sql: enable shared-process mode tenant testing for TestUnsplitRanges
7c40dd2 
I opened issue cockroachdb#142388 to track the work for enabling external-process mode
testing, as it turned out to be a non-trivial effort.
craig bot pushed a commit that referenced this issue Mar 18, 2025
@shubhamdhama
Merge #142391
cb94136 
142391: sql: increase tenant testing coverage r=rafiss,msbutler a=shubhamdhama

`` sql: increase tenant testing coverage for `jobs_profiler_execution_details_test` ``


`` sql: increase tenant testing coverage for `mvcc_backfiller_test` ``


`` sql: increase tenant testing coverage for `txn_restart_test` ``


`` sql: enable shared-process mode tenant testing for `TestUnsplitRanges` ``

I opened issue #142388 to track the work for enabling external-process mode
testing, as it turned out to be a non-trivial effort.

Informs: #140446
Epic: CRDB-48564
Release note: None


Co-authored-by: Shubham Dhama <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-multitenancy Related to multi-tenancy C-investigation Further steps needed to qualify. C-label will change.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shubhamdhama