Skip to content

Commit 6f4f374

Browse files
craig[bot]annrpom
craig[bot]
andcommittedMar 13, 2025·
Merge #140617
140617: schemachanger: remove RBR fallback for add column r=annrpom a=annrpom This patch removes the regional by row fallback for `ADD COLUMN` in the declarative schema changer. Epic: [CRDB-31282](https://cockroachlabs.atlassian.net/browse/CRDB-31282) Fixes: #80545 Release note: None Co-authored-by: Annie Pompa <[email protected]>
2 parents 7d83d51 + 254760e commit 6f4f374

17 files changed

+1597
-24
lines changed
 

‎pkg/ccl/schemachangerccl/ccl_generated_test.go

+70
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
setup
2+
CREATE DATABASE multiregion_db PRIMARY REGION "us-east1" REGIONS "us-east2", "us-east3" SURVIVE REGION FAILURE;
3+
CREATE TABLE multiregion_db.public.table_regional_by_row (
4+
k INT PRIMARY KEY,
5+
V STRING
6+
) LOCALITY REGIONAL BY ROW;
7+
----
8+
9+
stage-exec phase=PostCommitPhase stage=:
10+
USE multiregion_db;
11+
INSERT INTO table_regional_by_row VALUES ($stageKey);
12+
INSERT INTO table_regional_by_row VALUES ($stageKey * -1);
13+
DELETE FROM table_regional_by_row WHERE k = $stageKey;
14+
----
15+
16+
stage-exec phase=PostCommitPhase stage=:
17+
USE multiregion_db;
18+
SELECT crdb_internal.validate_multi_region_zone_configs()
19+
----
20+
21+
test
22+
ALTER TABLE multiregion_db.public.table_regional_by_row ADD COLUMN w TEXT NOT NULL DEFAULT 's';
23+
----

0 commit comments

Comments
 (0)
Please sign in to comment.