[BUGFIX] Awkward default IP filter

Use "*" for default value of IP filter option instead of
empty value.

Also add binary safe flag for fopen() call and correct
wrong PHPdocs.

Change-Id: I6dbf75c86e865714bd64fc7efbe3f8725a9d741f
Resolves: #78686
Releases: 3.0
Reviewed-on: https://review.typo3.org/50647
Reviewed-by: Francois Suter <[email protected]>
Tested-by: Francois Suter <[email protected]>

Author: Francois Suter

ChangeLog

@@ -1,6 +1,7 @@
 2016-11-13 Francois Suter <[email protected]>
 
 	* Verified compatibility with TYPO3 v8 (8.5.-dev), resolves #78626
+	* Corrected awkward default value for IP filtering, resolves #78686
 
 2016-11-09 Francois Suter <[email protected]>
 

Classes/Utility/UserFields.php

@@ -35,7 +35,7 @@ class UserFields
      * Returns the severity of the entry using TYPO3's icon and labels.
      *
      * @param array $parameters Information related to the field
-     * @param UserElement $userElement Reference to calling object
+     * @param UserElement $formObject Reference to calling object
      *
      * @return string The HTML for the form field
      */
@@ -73,7 +73,7 @@ public function displaySeverity($parameters, $formObject)
      * Returns the extra data as a nice HTML dump.
      *
      * @param array $PA Information related to the field
-     * @param UserElement $userElement Reference to calling object
+     * @param UserElement $formObject Reference to calling object
      *
      * @return string The HTML for the form field
      */

Classes/Writer/FileWriter.php

@@ -46,7 +46,7 @@ public function __construct($logger)
         // If the file path is valid, try opening the file
         $this->fileHandle = @fopen(
                 $absoluteFilePath,
-                'a'
+                'ab'
         );
         // Throw an exception if log file could not be opened properly
         if (!$this->fileHandle) {

ext_conf_template.txt

@@ -16,7 +16,7 @@ excludeKeys =
 includeKeys =
 
 # cat=general/filtering/c; type=string; label=LLL:EXT:devlog/Resources/Private/Language/Configuration.xlf:ip_filter
-ipFilter =
+ipFilter = *
 
 # cat=general/display/a; type=integer; label=Autorefresh frequency: Set the number of seconds between each refresh, when using the autorefresh feature
 refreshFrequency = 4