.coafile: Set max line length for project pages #583
Comments
|
Hello everyone, I would like to work on this issue. Please assign me to work on it. @jayvdb please give me a chance. |
|
@jayvdb Can you please guide me on how can I do this. |
|
Please read the issue carefully, as it explains how to proceed, and look at the linked pages and understand them. |
|
Yes @jayvdb I have added a section with 120 line and fixed all the code that was violating the condition. |
|
Unfortunately no other way. But lets create one after this .. coala/coala#5646 ;-) |
|
You can list directories in the ignore. Dunno if that helps much. |
character length. This commits ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Fixes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Fixes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Fixes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Fixes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Fixes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Fixes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Fixes coala#583
|
It looks like 120 CPL isn't enough for old files, you should use the max length that passes all the current files and then ignore them in a new section with 80 CPL limit. |
|
@ksdme Yes 120 was not enough so I fixed all those lines that were over 120 characters by splitting them up. And I have created the new section which ignores the old files and sets 80 cpl limit to new files. |
|
120 CPL limit for old files is flexible, changing so many files isn't. Change the limit to whatever is required to pass all the files without splitting all of them. |
|
I don't think there is a cpl limit that can be applied for all the files as many files were in the range of 200 and 300 and even more than that in some. |
|
Maybe have 300+ CPL, I think it is better than changing all files. WDYT @jayvdb |
|
Okay If the two of you agree. I will do it. 😄 |
@ksdme that surely isn't better that changing files |
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Fixes coala#583
Some files have links that are being reported as broken by the coala. These changes fixes these links so that the build passes. Fixes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Fixes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Closes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Closes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Closes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Closes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Closes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Closes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Closes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Closes coala#583
This commit ensures that the files in the _projects folder are having a maximum line length of 120 characters for existing files whereas 80 characters for new files. This feature helps to improve the ability to read the code and review it. Closes coala#583
Similar to coala/cEPs#134 , the project pages (i.e. pages in https://github.com/coala/projects/tree/master/_projects) should have a reasonable line length to improve the ability to read & code review them.
c.f. coala/cEPs#157
Try length 120 for existing files so it requires less disruptive changes to the existing files.
Then add another section which requires 80 cpl and excludes the existing files.
The text was updated successfully, but these errors were encountered: