WIP bears/go: Add GoMetaLinterBear #1933

Vamshi99 · 2017-07-16T10:12:03Z

Add GometalinterBear which replaces some of existing bears
like errcheck, vet etc

Closes #972

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

gitmate-bot · 2017-07-16T10:13:02Z

bears/go/GoMetaLinterBear.py

+    AUTHORS_EMAILS = {'[email protected]'}
+    LICENSE = 'AGPL-3.0'
+    CAN_DETECT = {'Formatting','Syntax','Missing import',
+                  'Unused Code', 'Smell', 'Unreachable Code','Security'}


E231 missing whitespace after ',''

PycodestyleBear (E231), severity NORMAL, section autopep8.

gitmate-bot · 2017-07-16T10:13:03Z

bears/go/GoMetaLinterBear.py

+    AUTHORS = {'The coala developers'}
+    AUTHORS_EMAILS = {'[email protected]'}
+    LICENSE = 'AGPL-3.0'
+    CAN_DETECT = {'Formatting','Syntax','Missing import',


E231 missing whitespace after ',''

PycodestyleBear (E231), severity NORMAL, section autopep8.

gitmate-bot · 2017-07-16T10:13:04Z

bears/go/GoMetaLinterBear.py

+    AUTHORS = {'The coala developers'}
+    AUTHORS_EMAILS = {'[email protected]'}
+    LICENSE = 'AGPL-3.0'
+    CAN_DETECT = {'Formatting','Syntax','Missing import',


E231 missing whitespace after ',''

PycodestyleBear (E231), severity NORMAL, section autopep8.

gitmate-bot · 2017-07-16T10:13:04Z

bears/go/GoMetaLinterBear.py

+    AUTHORS = {'The coala developers'}
+    AUTHORS_EMAILS = {'[email protected]'}
+    LICENSE = 'AGPL-3.0'
+    CAN_DETECT = {'Formatting','Syntax','Missing import',


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/go/GoMetaLinterBear.py +++ b/bears/go/GoMetaLinterBear.py @@ -17,8 +17,8 @@ AUTHORS = {'The coala developers'} AUTHORS_EMAILS = {'[email protected]'} LICENSE = 'AGPL-3.0' - CAN_DETECT = {'Formatting','Syntax','Missing import', - 'Unused Code', 'Smell', 'Unreachable Code','Security'} + CAN_DETECT = {'Formatting', 'Syntax', 'Missing import', + 'Unused Code', 'Smell', 'Unreachable Code', 'Security'} SEE_MORE = 'https://github.com/alecthomas/gometalinter' @staticmethod

gitmate-bot · 2017-07-16T10:13:05Z

tests/go/GoMetaLinterBearTest.py

+
+GoMetaLinterBearTest = verify_local_bear(GoMetaLinterBear,
+                                   valid_files=(good_file_errcheck,bad_file_imports),
+                                   invalid_files=(bad_file_errcheck,good_file_imports))


E501 line too long (87 > 79 characters)'

PycodestyleBear (E501), severity NORMAL, section autopep8.

gitmate-bot · 2017-07-16T10:13:06Z

tests/go/GoMetaLinterBearTest.py

+
+GoMetaLinterBearTest = verify_local_bear(GoMetaLinterBear,
+                                   valid_files=(good_file_errcheck,bad_file_imports),
+                                   invalid_files=(bad_file_errcheck,good_file_imports))


E231 missing whitespace after ',''

PycodestyleBear (E231), severity NORMAL, section autopep8.

gitmate-bot · 2017-07-16T10:13:07Z

tests/go/GoMetaLinterBearTest.py

+
+GoMetaLinterBearTest = verify_local_bear(GoMetaLinterBear,
+                                   valid_files=(good_file_errcheck,bad_file_imports),
+                                   invalid_files=(bad_file_errcheck,good_file_imports))


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-07-16T10:13:07Z

tests/go/GoMetaLinterBearTest.py

+
+
+GoMetaLinterBearTest = verify_local_bear(GoMetaLinterBear,
+                                   valid_files=(good_file_errcheck,bad_file_imports),


E501 line too long (85 > 79 characters)'

PycodestyleBear (E501), severity NORMAL, section autopep8.

gitmate-bot · 2017-07-16T10:13:08Z

tests/go/GoMetaLinterBearTest.py

+
+
+GoMetaLinterBearTest = verify_local_bear(GoMetaLinterBear,
+                                   valid_files=(good_file_errcheck,bad_file_imports),


E231 missing whitespace after ',''

PycodestyleBear (E231), severity NORMAL, section autopep8.

gitmate-bot · 2017-07-16T10:13:08Z

tests/go/GoMetaLinterBearTest.py

+
+
+GoMetaLinterBearTest = verify_local_bear(GoMetaLinterBear,
+                                   valid_files=(good_file_errcheck,bad_file_imports),


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-07-16T10:13:09Z

tests/go/GoMetaLinterBearTest.py

+
+
+GoMetaLinterBearTest = verify_local_bear(GoMetaLinterBear,
+                                   valid_files=(good_file_errcheck,bad_file_imports),


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/tests/go/GoMetaLinterBearTest.py +++ b/tests/go/GoMetaLinterBearTest.py @@ -35,5 +35,6 @@ GoMetaLinterBearTest = verify_local_bear(GoMetaLinterBear, - valid_files=(good_file_errcheck,bad_file_imports), - invalid_files=(bad_file_errcheck,good_file_imports)) + valid_files=( + good_file_errcheck, bad_file_imports), + invalid_files=(bad_file_errcheck, good_file_imports))

gitmate-bot · 2017-07-16T10:13:10Z

tests/go/GoMetaLinterBearTest.py

+
+GoMetaLinterBearTest = verify_local_bear(GoMetaLinterBear,
+                                   valid_files=(good_file_errcheck,bad_file_imports),
+                                   invalid_files=(bad_file_errcheck,good_file_imports))


Line is longer than allowed. (87 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2017-07-16T10:13:10Z

tests/go/GoMetaLinterBearTest.py

+
+
+GoMetaLinterBearTest = verify_local_bear(GoMetaLinterBear,
+                                   valid_files=(good_file_errcheck,bad_file_imports),


Line is longer than allowed. (85 > 79)

LineLengthBear, severity NORMAL, section linelength.

AsnelChristian · 2017-07-18T10:38:20Z

bears/go/GoMetaLinterBear.py

+        output_regex=r'(.*):(\d*):(\d*):(.*) \((\w*)\)')
+class GoMetaLinterBear:
+    """
+    Checks the code using ``gometalinter``. This will run


"go" codes right ?

AsnelChristian · 2017-07-18T10:45:30Z

bears/go/GoMetaLinterBear.py

+    SEE_MORE = 'https://github.com/alecthomas/gometalinter'
+
+    @staticmethod
+    def create_arguments(filename, file, config_file,


this is bear seems to be configurable

go vet - Reports potential errors that otherwise compile.
go tool vet --shadow - Reports variables that may have been unintentionally shadowed.
gotype - Syntactic and semantic analysis similar to the Go compiler.
deadcode - Finds unused code.
gocyclo - Computes the cyclomatic complexity of functions.
golint - Google's (mostly stylistic) linter.
varcheck - Find unused global variables and constants.
structcheck - Find unused struct fields.
aligncheck - Warn about un-optimally aligned structures.
errcheck - Check that error return values are used.
megacheck - Run staticcheck, gosimple and unused, sharing work.
dupl - Reports potentially duplicated code.
ineffassign - Detect when assignments to existing variables are not used.
interfacer - Suggest narrower interfaces that can be used.
unconvert - Detect redundant type conversions.
goconst - Finds repeated strings that could be replaced by a constant.
gas - Inspects source code for security problems by scanning the Go AST.

maybe you should make it configurable by enabling or disabling some linters ? 😅

@AsnelChristian PTAL 😃

AsnelChristian · 2017-07-18T10:49:57Z

please always run coala on the file you modified before pushing them

gitmate-bot · 2017-07-21T12:46:31Z

bears/go/GoMetaLinterBear.py

+@linter(executable='gometalinter.v1',
+        use_stdout=True,
+        output_format='regex',
+        output_regex=r'(.*):(?P<line>\d*):(?P<column>\d*):(?P<message>.*) \((?:\w*)\)')


Line is longer than allowed. (87 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2017-07-21T12:46:32Z

bears/go/GoMetaLinterBear.py

+@linter(executable='gometalinter.v1',
+        use_stdout=True,
+        output_format='regex',
+        output_regex=r'(.*):(?P<line>\d*):(?P<column>\d*):(?P<message>.*) \((?:\w*)\)')


E501 line too long (87 > 79 characters)'

PycodestyleBear (E501), severity NORMAL, section autopep8.

Add GometalinterBear which replaces some of existing bears like errcheck, vet etc Closes coala#972

yash-nisar · 2017-07-24T10:20:49Z

@Vamshi99 Please fix your tests.

yash-nisar · 2017-07-24T10:23:07Z

bears/go/GoMetaLinterBear.py

+        """
+        :param gometalinter_disable:
+            Disable a linter.
+        :param gometalinter_enable:


Not sure if we should list the supported linters for our users to know.

Seems like the user will need to install all the linters first ?

@yash-nisar Yeah, we should mention about all supported linters. Should I list them in the documentation section? Also I will add command to install all the linters.

yash-nisar · 2017-07-24T10:24:42Z

bears/go/GoMetaLinterBear.py

+    @staticmethod
+    def create_arguments(filename, file, config_file,
+                         gometalinter_disable: str='',
+                         gometalinter_enable: str='',


Can this be a list ? (enabling more than 1 linter)

Listing doesn't work here.
https://github.com/alecthomas/gometalinter#whats-the-best-way-to-use-gometalinter-in-ci

yash-nisar · 2017-07-24T10:27:27Z

tests/go/GoMetaLinterBearTest.py

+                                         valid_files=(good_file_errcheck,
+                                                      bad_file_imports),
+                                         invalid_files=(bad_file_errcheck,
+                                                        good_file_imports))


Maybe a test with a config_file ?

yash-nisar · 2017-07-24T10:27:46Z

tests/go/GoMetaLinterBearTest.py

@@ -0,0 +1,40 @@
+from bears.go.GoMetaLinterBear import GoMetaLinterBear
+from coalib.testing.LocalBearTestHelper import verify_local_bear
+


2 lines before the code begins 😄

yash-nisar · 2017-07-24T10:28:35Z

tests/go/GoMetaLinterBearTest.py

@@ -0,0 +1,40 @@
+from bears.go.GoMetaLinterBear import GoMetaLinterBear


Imports should be like :

from coalib.testing.LocalBearTestHelper import verify_local_bear from bears.go.GoMetaLinterBear import GoMetaLinterBear

Any reason? I think many of the tests are not written in that pattern 🤔

I agree, we need to correct them, see PEP8 imports for more information.

gitmate-bot added process/pending review size/M review carefully! labels Jul 16, 2017

Vamshi99 changed the title ~~bears/go: Add GoMetaLinterBear~~ WIP bears/go: Add GoMetaLinterBear Jul 16, 2017

gitmate-bot reviewed Jul 16, 2017

View reviewed changes

AsnelChristian requested changes Jul 18, 2017

View reviewed changes

co-robo added process/wip and removed process/pending review labels Jul 18, 2017

Vamshi99 force-pushed the metalinter branch 3 times, most recently from 234469e to 92d1580 Compare July 21, 2017 12:45

gitmate-bot reviewed Jul 21, 2017

View reviewed changes

bears/go: Add GoMetaLinterBear

40278a3

Add GometalinterBear which replaces some of existing bears like errcheck, vet etc Closes coala#972

Vamshi99 force-pushed the metalinter branch from 92d1580 to 40278a3 Compare July 21, 2017 12:49

co-robo added process/pending review and removed process/wip labels Jul 22, 2017

yash-nisar reviewed Jul 24, 2017

View reviewed changes

co-robo added process/wip and removed process/pending review labels Jul 24, 2017

gitmate-bot added the status/STALE label Aug 31, 2017

Vamshi99 closed this Jan 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP bears/go: Add GoMetaLinterBear #1933

WIP bears/go: Add GoMetaLinterBear #1933

Vamshi99 commented Jul 16, 2017

gitmate-bot Jul 16, 2017

gitmate-bot Jul 16, 2017

gitmate-bot Jul 16, 2017

gitmate-bot Jul 16, 2017

gitmate-bot Jul 16, 2017

gitmate-bot Jul 16, 2017

gitmate-bot Jul 16, 2017

gitmate-bot Jul 16, 2017

gitmate-bot Jul 16, 2017

gitmate-bot Jul 16, 2017

gitmate-bot Jul 16, 2017

gitmate-bot Jul 16, 2017

gitmate-bot Jul 16, 2017

AsnelChristian Jul 18, 2017

AsnelChristian Jul 18, 2017

AsnelChristian Jul 18, 2017

AsnelChristian Jul 18, 2017

Vamshi99 Jul 21, 2017

AsnelChristian commented Jul 18, 2017

gitmate-bot Jul 21, 2017

gitmate-bot Jul 21, 2017

yash-nisar commented Jul 24, 2017

yash-nisar Jul 24, 2017

yash-nisar Jul 24, 2017

Vamshi99 Jul 24, 2017 •

edited

Loading

yash-nisar Jul 24, 2017

Vamshi99 Jul 24, 2017

yash-nisar Jul 24, 2017

yash-nisar Jul 24, 2017

yash-nisar Jul 24, 2017

Vamshi99 Jul 24, 2017

yash-nisar Jul 24, 2017 •

edited

Loading



		GoMetaLinterBearTest = verify_local_bear(GoMetaLinterBear,
		valid_files=(good_file_errcheck,bad_file_imports),

		@@ -0,0 +1,40 @@
		from bears.go.GoMetaLinterBear import GoMetaLinterBear
		from coalib.testing.LocalBearTestHelper import verify_local_bear

WIP bears/go: Add GoMetaLinterBear #1933

WIP bears/go: Add GoMetaLinterBear #1933

Conversation

Vamshi99 commented Jul 16, 2017

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AsnelChristian commented Jul 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yash-nisar commented Jul 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vamshi99 Jul 24, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yash-nisar Jul 24, 2017 • edited Loading

Choose a reason for hiding this comment

Vamshi99 Jul 24, 2017 •

edited

Loading

yash-nisar Jul 24, 2017 •

edited

Loading