Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bear for go-metalinter #972

Open
coala-bot opened this issue Nov 4, 2016 · 10 comments
Open

Add bear for go-metalinter #972

coala-bot opened this issue Nov 4, 2016 · 10 comments
Assignees
@manankalra
Labels
area/lintbears bear proposal difficulty/low

Comments

@coala-bot
Copy link

https://github.com/alecthomas/gometalinter#go-meta-linter-

Opened via gitter by @adtac
@adtac
Copy link
Member

adtac commented Nov 4, 2016 •
edited
Loading

this would be a terrific bear that provides a all-in-one support for all go related things

Vamshi99 added a commit to Vamshi99/coala-bears that referenced this issue Jul 16, 2017
@Vamshi99
bears/go: Add GoMetaLinterBear
291afe8 
Replace all go linters currently present in coala
with GoMetaLinterBear as it contains a set of useful
go linters including ours

Closes coala#972
Vamshi99 added a commit to Vamshi99/coala-bears that referenced this issue Jul 16, 2017
@Vamshi99
bears/go: Add GoMetaLinterBear
f52611c 
Add GometalinterBear which replaces some of existing bears
like errcheck, vet etc

Closes coala#972
@Vamshi99 Vamshi99 mentioned this issue Jul 16, 2017
Closed
2 tasks
Vamshi99 added a commit to Vamshi99/coala-bears that referenced this issue Jul 18, 2017
@Vamshi99
bears/go: Add GoMetaLinterBear
a33cf1c 
Add GometalinterBear which replaces some of existing bears
like errcheck, vet etc

Closes coala#972
Vamshi99 added a commit to Vamshi99/coala-bears that referenced this issue Jul 18, 2017
@Vamshi99
bears/go: Add GoMetaLinterBear
234469e 
Add GometalinterBear which replaces some of existing bears
like errcheck, vet etc

Closes coala#972
Vamshi99 added a commit to Vamshi99/coala-bears that referenced this issue Jul 21, 2017
@Vamshi99
bears/go: Add GoMetaLinterBear
92d1580 
Add GometalinterBear which replaces some of existing bears
like errcheck, vet etc

Closes coala#972
Vamshi99 added a commit to Vamshi99/coala-bears that referenced this issue Jul 21, 2017
@Vamshi99
bears/go: Add GoMetaLinterBear
40278a3 
Add GometalinterBear which replaces some of existing bears
like errcheck, vet etc

Closes coala#972
@SanketDG
Copy link
Member

SanketDG commented Dec 6, 2017

We should also probably drop bears that is supported by it, to avoid duplication

@Makman2
Copy link
Member

Makman2 commented Dec 10, 2017

@SanketDG yeah can be done in a next step. File an issue and mark it as blocked by this one ;)

@adtac
Copy link
Member

adtac commented Dec 11, 2017

Drop as in completely delete them? I don't know about that. Some people might hate go-metalinter and might just want one of the individual linters.

Maybe add a notice informing the user that there's a bear that's a superset.

@Vamshi99
Copy link
Member

Maintainers, unassign me.

@manankalra
Copy link
Contributor

@Makman2
Assign it to me, please. :)

@manankalra
Copy link
Contributor

@adtac @Makman2

Some people might hate go-metalinter and might just want one of the individual linters.

GoMetaLinter supports enabling and disabling individual linters.

This is what the scenario is:

  • A few linters run and some of them are disabled by default. https://goo.gl/gMirRv
  • For enabling an already disabled linter or for disabling a linter which it runs by defaut, flags can be used.
  • The problem is: those flags do not accept comma-separated or space-separated lists (for enabling/disabling multilple linters)
  • Rather, the --enable or --disable flag need to be used repeatedly for it. Or a configuration file can be used.

So, should I take a typed_list and then alter the arguments to make repeated use of a single flag in the same command or just a single value is fine (I'll add a comment to use config_files in order to enable/disable multiple linters)?

@Makman2
Copy link
Member

Makman2 commented Feb 22, 2018

yeah sounds good @manankalra , however this

Some people might hate go-metalinter and might just want one of the individual linters.

was more related to this:

We should also probably drop bears that is supported by it, to avoid duplication

;)

@manankalra
Copy link
Contributor

manankalra commented Feb 22, 2018 •
edited
Loading

Yeah, I read that.
and because of

GoMetaLinter supports enabling and disabling individual linters.

dropping bears that are supported by it can be given a thought. ;)

@Makman2
Copy link
Member

Makman2 commented Feb 22, 2018 •
edited
Loading

Yeah indeed, but different issue :)
(can be filed once this one is solved)

manankalra added a commit to manankalra/coala-bears that referenced this issue Feb 22, 2018
@manankalra
GoMetaLintBear: Add bear implementation
699b41a 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
@gitmate-bot gitmate-bot mentioned this issue Mar 10, 2018
Open
@manankalra manankalra mentioned this issue Mar 13, 2018
Open
@jayvdb jayvdb mentioned this issue Apr 6, 2018
Open
manankalra added a commit to manankalra/coala-bears that referenced this issue Apr 7, 2018
@manankalra
GoMetaLintBear: Add bear implementation
0194c7f 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue Apr 7, 2018
@manankalra
GoMetaLintBear: Add bear implementation
8d2effe 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue Apr 7, 2018
@manankalra
GoMetaLintBear: Add bear implementation
b7816d6 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue Apr 8, 2018
@manankalra
GoMetaLintBear: Add bear implementation
b2c1b24 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue Apr 18, 2018
@manankalra
GoMetaLintBear: Add bear implementation
ae8b4e9 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue May 1, 2018
@manankalra
GoMetaLintBear: Add bear implementation
d0a4549 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
gitmate-bot pushed a commit to manankalra/coala-bears that referenced this issue May 2, 2018
@manankalra @gitmate-bot
GoMetaLintBear: Add bear implementation
3a9322a 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue May 2, 2018
@manankalra
GoMetaLintBear: Add bear implementation
e763477 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue May 2, 2018
@manankalra
GoMetaLintBear: Add bear implementation
3a43611 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue May 2, 2018
@manankalra
GoMetaLintBear: Add bear implementation
b5b0411 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue May 3, 2018
@manankalra
GoMetaLintBear: Add bear implementation
73058ec 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue May 9, 2018
@manankalra
GoMetaLintBear: Add bear implementation
c892d55 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue May 10, 2018
@manankalra
GoMetaLintBear: Add bear implementation
a4979bc 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue May 10, 2018
@manankalra
GoMetaLintBear: Add bear implementation
3d31f04 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue May 10, 2018
@manankalra
GoMetaLintBear: Add bear implementation
03ab8ea 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
manankalra added a commit to manankalra/coala-bears that referenced this issue May 10, 2018
@manankalra
GoMetaLintBear: Add bear implementation
fd8d3f9 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
gitmate-bot pushed a commit to manankalra/coala-bears that referenced this issue May 11, 2018
@manankalra @gitmate-bot
GoMetaLintBear: Add bear implementation
410a9d4 
Lints Go code.
Runs a set of linters to check for all possible
issues.

Closes coala#972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manankalra manankalra

Labels
area/lintbears bear proposal difficulty/low
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP bears/go: Add GoMetaLinterBear Vamshi99/coala-bears
7 participants
@Makman2 @adtac @SanketDG @manankalra @gitmate-bot @Vamshi99 @coala-bot