ClangFunctionDifferenceBear.py: Fix function addresses in optional se… #2256
Conversation
|
Comment on 8e53ede. Shortlog of the HEAD commit contains 76 character(s). This is 26 character(s) longer than the limit (76 > 50). Origin: GitCommitBear, Section: |
There was a problem hiding this comment.
Your shortlog is too long. Please follow http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html for writing commit messages.
Removes function addresses under optional settings in the bear's description. Fixes coala#559
vibhanshuvaibhav
force-pushed
the
issue559
branch
from
8e53ede to
bcc6e07
Compare
| @@ -87,7 +87,7 @@ class ClangFunctionDifferenceBear(GlobalBear): | |||
| REQUIREMENTS = ClangBear.REQUIREMENTS | {PipRequirement('munkres3', '1.0')} | |||
|
|
|||
| def run(self, | |||
| counting_conditions: counting_condition_dict=default_cc_dict, | |||
| counting_conditions: default_cc_dict=counting_condition_dict, | |||
There was a problem hiding this comment.
Can you explain why have you changed this and you have tests failing due to this change ;)
There was a problem hiding this comment.
So far the only explanation I have is that the default_cc_dict is generated by the counting_condition_dict. So, I made the change locally and the function values didn't appear then.
There was a problem hiding this comment.
This might need some corresponding changes in the tests as well. Could be the reason for failing tests.
There was a problem hiding this comment.
This is not the solution.
The type and default of this method arg are correct, and changing them will break stuff.
however, the default of this arg isnt able to be printed & read by a user.
This probably needs to be improved in http://github.com/coala/coala
Removes function addresses in optional
settings of the bear's description.
Fixes #559
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!