Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LatexLintBear: Format error #1876

Open
gaocegege opened this issue Jul 1, 2017 · 19 comments · May be fixed by #2399
Open

LatexLintBear: Format error #1876

gaocegege opened this issue Jul 1, 2017 · 19 comments · May be fixed by #2399

Comments

@gaocegege
Copy link
Member

gaocegege commented Jul 1, 2017

Hi, I find a weird thing in LatexLintBear:

|    | [NORMAL] LatexLintBear:
|    | Wrong length of dash may have been used.!n
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

There is a n after the message, but I am not sure if we should remove or replace it with \n

And, you can see that there is .! at the end, I am not sure whether it is a bug or feature.

@gaocegege
Copy link
Member Author

#dibs #1873

@Makman2
Copy link
Member

Makman2 commented Jul 1, 2017

Sounds like we need to adapt the regex.

Btw: Why does the + indicate a patch there? That looks kinda bad :O Or is that a typo @gaocegege ?

@gaocegege
Copy link
Member Author

Hi @Makman2 There is no + in the message, I uses diff to show the line clearly.

@Makman2
Copy link
Member

Makman2 commented Jul 2, 2017

@gaocegege Don't insert special characters for such scenarios ;) That's often confusing :)

@gaocegege
Copy link
Member Author

Yeah, sorry for that

@RaiVaibhav
Copy link
Member

@gaocegege working on issue?? I would like work on it

@gaocegege
Copy link
Member Author

I am not on it, good luck to you :)

@RaiVaibhav
Copy link
Member

RaiVaibhav commented Oct 27, 2017

@gaocegege aah i noticed you already made a PR, just curious to know why you close the PR ??

@gaocegege
Copy link
Member Author

#1873 is trying to fix the problem but I have no idea if it works well by adding the \.

@RaiVaibhav
Copy link
Member

@gaocegege please unassign yourself so that i can assign my self

@co-robo co-robo assigned RaiVaibhav and unassigned gaocegege Oct 28, 2017
@prnvdixit
Copy link
Member

@RaiVaibhav It's in GCI task list too... 😟

@RaiVaibhav
Copy link
Member

@prnvdixit can you send list of all gci task

@prnvdixit
Copy link
Member

See header of coala/gci channel 😄

@RaiVaibhav
Copy link
Member

Ok thanks

@kriti21
Copy link
Contributor

kriti21 commented Feb 7, 2018

Please assign this to me.

@gaocegege
Copy link
Member Author

@k4ni5h Thank you and you could use corobo to assign it to you in gitter.

kriti21 added a commit to kriti21/coala-bears that referenced this issue Feb 7, 2018
This removes the  extra !n from the messages
generated by LatexLintBear.

Closes coala#1876
kriti21 added a commit to kriti21/coala-bears that referenced this issue Feb 8, 2018
This removes the  extra !n from the messages
generated by LatexLintBear.

Fixes coala#1876
kriti21 added a commit to kriti21/coala-bears that referenced this issue Feb 8, 2018
This removes the  extra !n from the messages
generated by LatexLintBear.

Fixes coala#1876
kriti21 added a commit to kriti21/coala-bears that referenced this issue Feb 10, 2018
This removes the  extra !n from the messages
generated by LatexLintBear.

Fixes coala#1876
@damian1996
Copy link
Contributor

damian1996 commented Mar 4, 2018

@kriti21 Do you still work at this? :)

@Makman2 Please assign me to this :)

@kriti21
Copy link
Contributor

kriti21 commented Mar 4, 2018

@Makman2 Please unassign me from this issue.

@kriti21
Copy link
Contributor

kriti21 commented Mar 4, 2018

@damian1996 Also please feel free to refer my PR and comments on that. You will surely find it useful :)

@Makman2 Makman2 assigned damian1996 and unassigned kriti21 Mar 4, 2018
damian1996 added a commit to damian1996/coala-bears that referenced this issue Apr 1, 2018
This removes the extra !n from the messages generated
by LatexLintBear and add a test to check it.

Fixes coala#1876
@damian1996 damian1996 linked a pull request Apr 1, 2018 that will close this issue
2 tasks
damian1996 added a commit to damian1996/coala-bears that referenced this issue Apr 1, 2018
This removes the extra !n from the messages generated
by LatexLintBear and add a test to check it.

Fixes coala#1876
damian1996 added a commit to damian1996/coala-bears that referenced this issue Apr 1, 2018
This removes the extra !n from the messages generated
by LatexLintBear and add a test to check it.

Fixes coala#1876
damian1996 added a commit to damian1996/coala-bears that referenced this issue Apr 2, 2018
This removes the extra !n from the messages generated
by LatexLintBear and add a test to check it.

Fixes coala#1876
damian1996 added a commit to damian1996/coala-bears that referenced this issue Apr 2, 2018
This removes the extra !n from the messages generated
by LatexLintBear and add a test to check it.

Fixes coala#1876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

8 participants