SpaceConsistencyBear: Remove trailing blank lines option

[meetmangukiya]

I think removing trailing whitespace exists in some bears, but is language dependent. Haven't found a bear that removes trailing blank lines though

[jayvdb]

This would go into SpaceConsistencyBear I think? It does trailing whitespace per line, and enforce_newline_at_EOF , but not trailing blank lines..?

[meetmangukiya]

@jayvdb yes, you are right, it should go into SpaceConsistencyBear 👍

[khanchi97]

@danlls are you still working on this?If not, then I would like to do it.

[danlls]

I'm not, you can go ahead. Somebody can withdraw me from assignee

[khanchi97]

@jayvdb @meetmangukiya I want to ask one thing.Let say in a file, if there are some trailing blanklines at EOF with whitespaces in these lines.So now when running SpaceConsistencyBear(I have made changes for allow_trailing_blanklines option), first it offers to delete those lines using applypatch action and if I use this action and after deleting those lines, now coala offers to remove whitespace from those lines which are already deleted by allow_trailing_blanklines option.

[Makman2]

Pick the behaviour that is most intuitive and most understandable from user perspective ;)

[khanchi97]

No, I want to ask how I can fix this problem that if those lines have already deleted by allow_trailing_blanklines option then why in next step coala offers to remove whitespace from those lines which have been already deleted.

[Makman2]

Fix that behaviour and make the bear not emit patches for those lines any more 👍
I don't know in detail how to fix it ;)