PHPCodeBeautifierBear: Add PHPCodeBeautifierBear #2156

bhavishyagopesh · 2017-12-08T20:29:08Z

Adds PHPCodeBeautifierBear that supports detection and
fixing of php code.

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

bhavishyagopesh · 2017-12-20T09:10:56Z

@SanketDG I made the required changes

SanketDG · 2017-12-20T11:56:34Z

.travis.yml

@@ -103,6 +103,9 @@ before_install:
      sed -i.bak '/^coala/d' requirements.txt
      sed -i.bak '/^mypy-lang/d' requirements.txt bear-requirements.txt
    fi
+  # On ubuntu:14.04 this seems the best way to install `phpcbf`
+  # With ubuntu:16.04 `php-codesniffer` contains `phpcbf`
+  - sudo pear install PHP_CodeSniffer


can you use the newer composer here?

also, you have to put this in a new shell script, .ci/deps.composer.sh, look at other package manager shell scripts to see how it is done

but still this needs to be moved preferably to .ci/deps.sh

SanketDG · 2017-12-20T12:12:06Z

Just realised its already there https://github.com/coala/coala-bears/blob/master/.ci/deps.apt.sh#L28 since we have the codesniffer bear, so you dont need anything in .travis.yml ideally. there are a bunch of other php linting tools that should be served by composer, I have opened #2187 for that, but thats a separate issue

bhavishyagopesh · 2017-12-20T12:15:04Z

@SanketDG No that was the problem actually with ubuntu:14.04(which the ci uses if it were 16.04 it would work), php-codesniffer(for ubuntu:14.04) package does not come with phpcbf binary(or atleast does not puts it into $PATH), that's why I had to pear-install it separately

SanketDG · 2017-12-20T12:24:37Z

@bhavishyagopesh that makes sense, it probably carries an old version, I am up for using pear right now and then move to composer when #2187 is implemented.

bhavishyagopesh · 2017-12-20T12:27:20Z

@SanketDG If you say, I tested the composer setup locally just now(inside ubuntu docker), I can add the deps.composer.sh file...than we'll probably not need php-codesniffer in apt-packages

SanketDG · 2017-12-20T13:42:00Z

we'll probably not need php-codesniffer in apt-packages

yup that would be a separate PR

bhavishyagopesh · 2017-12-29T08:16:17Z

@SanketDG the appveyor ci fails because of missing phpcbf executable, (and also it's not having pear).So how should I add that dependency?

palash25 · 2017-12-23T06:17:22Z

bears/php/PHPCodeBeautifierBear.py

+    return os.path.join(os.path.dirname(__file__), name)
+
+
+def load_testfile(name):


If you have a look at other bears these 2 methods (get_testfile_path and load_testfile) are used in the test files of bear and not the file that wraps the linter. So these 2 function names didn't make sense to me when I first read your code and then I realized that you use them to load the sample config file (if I'm not wrong). So I think it would be better to rename these methods as get_configfile_path and load_configfile respectively. It would make much more sense to someone who reads your code in the future. 😄

Adds `PHPCodeBeautifierBear` that supports detection and fixing of php code. Closes coala#1771

newbazz

IMO it takes the pear to be pre installed which is not the case, so u need to install the pear.

SanketDG · 2018-01-04T18:36:24Z

I have no idea how to add pear to windows, if you cant figure it out from googling, its probably not supported well enough, so just feel free to skip the tests on windows.

jayvdb · 2018-04-10T01:58:41Z

.ci/appveyor.yml

@@ -39,6 +39,7 @@ install:
  # Check that we have the expected version and architecture for Python
  - "python --version"
  - "python -c \"import struct; print(struct.calcsize('P') * 8)\""
+  - "pear install PHP_CodeSniffer"


add the skip decorator to your test class, so you dont need to install pear onto windows.

gitmate-bot added process/pending review size/M area/lintbears bear proposal difficulty/medium importance/medium labels Dec 8, 2017

gitmate-bot assigned bhavishyagopesh Dec 8, 2017

bhavishyagopesh force-pushed the feat/phpcbf branch 3 times, most recently from c9cf9ff to 12c1da7 Compare December 9, 2017 19:45

gitmate-bot added size/S and removed size/M labels Dec 9, 2017

bhavishyagopesh force-pushed the feat/phpcbf branch from 12c1da7 to b1eb249 Compare December 9, 2017 20:44

gitmate-bot added size/M and removed size/S labels Dec 9, 2017

bhavishyagopesh force-pushed the feat/phpcbf branch from b1eb249 to 450a52c Compare December 9, 2017 22:50

gitmate-bot added size/S and removed size/M labels Dec 9, 2017

bhavishyagopesh force-pushed the feat/phpcbf branch 11 times, most recently from 02b306d to f94558c Compare December 16, 2017 05:15

bhavishyagopesh force-pushed the feat/phpcbf branch from f94558c to f035fe6 Compare December 19, 2017 06:34

bhavishyagopesh force-pushed the feat/phpcbf branch 2 times, most recently from 3b118e3 to ca19565 Compare December 20, 2017 07:08

gitmate-bot added size/M and removed size/S labels Dec 20, 2017

SanketDG requested changes Dec 20, 2017

View reviewed changes

bhavishyagopesh force-pushed the feat/phpcbf branch 2 times, most recently from 2c1f830 to 2e9e2bd Compare December 20, 2017 12:49

bhavishyagopesh force-pushed the feat/phpcbf branch 5 times, most recently from c09d423 to 8ca602c Compare December 26, 2017 17:50

bhavishyagopesh force-pushed the feat/phpcbf branch 2 times, most recently from 79c0ce1 to e223ae1 Compare December 29, 2017 08:14

palash25 suggested changes Dec 29, 2017

View reviewed changes

bhavishyagopesh force-pushed the feat/phpcbf branch from e223ae1 to 92f3805 Compare December 29, 2017 11:08

PHPCodeBeautifierBear: Add PHPCodeBeautifierBear

92f3805

Adds `PHPCodeBeautifierBear` that supports detection and fixing of php code. Closes coala#1771

newbazz reviewed Jan 4, 2018

View reviewed changes

SanketDG approved these changes Jan 4, 2018

View reviewed changes

jayvdb requested changes Apr 10, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Apr 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHPCodeBeautifierBear: Add PHPCodeBeautifierBear #2156

PHPCodeBeautifierBear: Add PHPCodeBeautifierBear #2156

bhavishyagopesh commented Dec 8, 2017 •

edited

Loading

bhavishyagopesh commented Dec 20, 2017

SanketDG Dec 20, 2017

SanketDG Dec 20, 2017

SanketDG commented Dec 20, 2017 •

edited

Loading

bhavishyagopesh commented Dec 20, 2017 •

edited

Loading

SanketDG commented Dec 20, 2017

bhavishyagopesh commented Dec 20, 2017

SanketDG commented Dec 20, 2017

bhavishyagopesh commented Dec 29, 2017

palash25 Dec 23, 2017

newbazz left a comment

SanketDG commented Jan 4, 2018

jayvdb Apr 10, 2018

		return os.path.join(os.path.dirname(__file__), name)


		def load_testfile(name):

PHPCodeBeautifierBear: Add PHPCodeBeautifierBear #2156

Are you sure you want to change the base?

PHPCodeBeautifierBear: Add PHPCodeBeautifierBear #2156

Conversation

bhavishyagopesh commented Dec 8, 2017 • edited Loading

Checklist

bhavishyagopesh commented Dec 20, 2017

SanketDG Dec 20, 2017

Choose a reason for hiding this comment

SanketDG Dec 20, 2017

Choose a reason for hiding this comment

SanketDG commented Dec 20, 2017 • edited Loading

bhavishyagopesh commented Dec 20, 2017 • edited Loading

SanketDG commented Dec 20, 2017

bhavishyagopesh commented Dec 20, 2017

SanketDG commented Dec 20, 2017

bhavishyagopesh commented Dec 29, 2017

palash25 Dec 23, 2017

Choose a reason for hiding this comment

newbazz left a comment

Choose a reason for hiding this comment

SanketDG commented Jan 4, 2018

jayvdb Apr 10, 2018

Choose a reason for hiding this comment

bhavishyagopesh commented Dec 8, 2017 •

edited

Loading

SanketDG commented Dec 20, 2017 •

edited

Loading

bhavishyagopesh commented Dec 20, 2017 •

edited

Loading