-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuotesBear broken by Python triple quotes #1103
Comments
oh yes, @abhsag24 was working on fixing this already |
What's the status here please ? @rohanraju97 |
I think @abhsag24 has ongoing work on this? |
I worked on this for a while, but then started working on my gsoc project. I will do it once the application date for gsoc is crossed. If someone wants to take care of this issue in the meantime, I'll unassign myself. @sils I didn't know that. The issue didn't have any assignees when I saw it so I assigned it to myself. |
I did. Then @aptrishu took it into his own PR idk if it solves it
completely but it's a step in this direction
On 16-Mar-2017 1:17 PM, "Rohan Raju" <[email protected]> wrote:
I worked on this for a while, but then started working on my gsoc project.
I will do it once the application date for gsoc is crossed. If someone
wants to take care of this issue in the meantime, I'll unassign myself.
@sils <https://github.com/sils> I didn't know that. The issue didn't have
any assignees when I saw it so I assigned it to myself.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1103 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIIwP8XCu8F9sPGXtVlwnyy8U2mh9YnSks5rmOj6gaJpZM4LFhFQ>
.
|
Ok, I'll look into it, if my PR already solves it or not. |
#1024 relevant ? @abhsag24 |
yup this happens since annotationBear doesnt diferentiate between single line and multiline strings, It should get solved when it correctly identifies. |
@abhsag24 state of this? This needs to get fixed :/ |
with the new annotationBear, it can identify singleline and multiline strings clearly. So, that should solve this problem. |
bump bump bump, I hit this again... it seems broken only on single line triple quotes |
you can speed this up by reviewing
#1332
Sincerely,
Lasse Schuirmann
[email protected]
http://coala.io/ - http://viperdev.io/ - http://gitmate.com/
…On 5 June 2017 at 14:01, Meet Mangukiya ***@***.***> wrote:
bump bump bump, I hit this again... it seems broken only on single line
triple quotes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1103 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFc6KDTcWQSSRDWm1B6Rp0QuRmjuaf3fks5sA-4hgaJpZM4LFhFQ>
.
|
What's the status here, please? @rohanraju97 @sils |
cc @userzimmermann , new AnnotationBear will fix it. |
This is a bad suggestion:
type/bug
The text was updated successfully, but these errors were encountered: