Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuotesBear broken by Python triple quotes #1103

Open
underyx opened this issue Dec 6, 2016 · 15 comments
Open

QuotesBear broken by Python triple quotes #1103

underyx opened this issue Dec 6, 2016 · 15 comments

Comments

@underyx
Copy link
Member

underyx commented Dec 6, 2016

This is a bad suggestion:

 class StructlogBear(LocalBear):
-    """Checks for correct usage of structlog"""
+    '""Checks for correct usage of structlog""'

type/bug

@sils
Copy link
Member

sils commented Dec 6, 2016

oh yes, @abhsag24 was working on fixing this already

@netman92
Copy link
Contributor

netman92 commented Mar 16, 2017

What's the status here please ? @rohanraju97

@sils
Copy link
Member

sils commented Mar 16, 2017

I think @abhsag24 has ongoing work on this?

@rohanraju97
Copy link
Contributor

I worked on this for a while, but then started working on my gsoc project. I will do it once the application date for gsoc is crossed. If someone wants to take care of this issue in the meantime, I'll unassign myself. @sils I didn't know that. The issue didn't have any assignees when I saw it so I assigned it to myself.

@abh3po
Copy link
Member

abh3po commented Mar 16, 2017 via email

@aptrishu
Copy link
Member

Ok, I'll look into it, if my PR already solves it or not.

@aptrishu
Copy link
Member

#1024 relevant ? @abhsag24

@abh3po
Copy link
Member

abh3po commented Mar 17, 2017

yup this happens since annotationBear doesnt diferentiate between single line and multiline strings, It should get solved when it correctly identifies.

@sils
Copy link
Member

sils commented May 24, 2017

@abhsag24 state of this? This needs to get fixed :/

@aptrishu
Copy link
Member

with the new annotationBear, it can identify singleline and multiline strings clearly. So, that should solve this problem.

@meetmangukiya
Copy link
Member

bump bump bump, I hit this again... it seems broken only on single line triple quotes

@sils
Copy link
Member

sils commented Jun 6, 2017 via email

@netman92
Copy link
Contributor

What's the status here, please? @rohanraju97 @sils

@aptrishu
Copy link
Member

cc @userzimmermann , new AnnotationBear will fix it.

@userzimmermann
Copy link
Member

@aptrishu We can go with #1332 first and later think again about pygments and #2096 for some simplification... As long as the AnnotationBear does what it should :)

cc @netman92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

9 participants