relative light bug fixed

Author: ponchio

relight/normalstask.cpp

@@ -194,7 +194,7 @@ void NormalsWorker::solveL2()
 			mPixel(m, 0) = m_Row[p][m].mean();
 
 		if(m_Imageset.light3d) {
-			for(size_t i = 0; i < m_Lights.size(); i++) {
+			for(size_t i = 0; i < m_Lights3d.size(); i++) {
 				Vector3f light = m_Imageset.relativeLight(m_Lights3d[i], p, row);
 				light.normalize();
 				for (int j = 0; j < 3; j++)
@@ -203,17 +203,15 @@ void NormalsWorker::solveL2()
 		}
 
 
-        // Solve
-        mNormals = (mLights.transpose() * mLights).ldlt().solve(mLights.transpose() * mPixel);
-        mNormals.col(0).normalize();
 
-        // Save
-        m_Normals[normalIdx+0] = mNormals(0,0);
-        m_Normals[normalIdx+1] = mNormals(1,0);
-        m_Normals[normalIdx+2] = mNormals(2,0);
+		mNormals = (mLights.transpose() * mLights).ldlt().solve(mLights.transpose() * mPixel);
+		mNormals.col(0).normalize();
+		m_Normals[normalIdx+0] = mNormals(0,0);
+		m_Normals[normalIdx+1] = mNormals(1,0);
+		m_Normals[normalIdx+2] = mNormals(2,0);
 
 		normalIdx += 3;
-    }
+	}
 }
 
 void NormalsWorker::solveSBL()

src/imageset.cpp

@@ -277,8 +277,8 @@ Vector3f ImageSet::relativeLight(const Vector3f &light3d, int x, int y){
 	//relative position to the center in cm
 	float dx = image_width_cm*(x - image_width/2.0f)/image_width;
 	float dy = image_width_cm*(y - image_height/2.0f)/image_width;
-	l[0]  -= dx;
-	l[1]  -= dy;
+	l[0]  -= dx/2;
+	l[1]  -= dy/2;
 	l[2]  += vertical_offset;
 	return l;
 }

src/project.cpp

@@ -533,7 +533,7 @@ void  Project::computeDirections() {
 					v = v.rotate(axis, angle);
 
 				if(dome.domeDiameter) {
-				//find intersection between direAlignctions and sphere.
+				//find intersection between directions and sphere.
 					for(size_t i = 0; i < sphere->directions.size(); i++) {
 						Vector3f &direction = sphere->directions[i];
 						direction.normalize();