Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACTION] Proposal 3 - Collect & Compute #147

Open
AntonioDiTuri opened this issue Dec 11, 2024 · 11 comments
Open

[ACTION] Proposal 3 - Collect & Compute #147

AntonioDiTuri opened this issue Dec 11, 2024 · 11 comments
Assignees
Labels

Comments

@AntonioDiTuri
Copy link
Contributor

AntonioDiTuri commented Dec 11, 2024

This issue details what needs to be done in the collect step.

You can reference the proposal 3 - Metrics section: https://github.com/cncf-tags/green-reviews-tooling/blob/main/docs/proposals/proposal-003-report.md#metrics.

There three substeps:

  1. collect the project metrics
  2. collect the metadata
  3. compute the sci

1. The metrics we will need to collect are

container_cpu_usage_seconds_total
container_memory_rss
container_memory_working_set_bytes

All the metrics should be available in prometheus, and we should be able to collect them with a PromQL query.

2. Collect the metadata

After collecting the metrics we need to collect the metadata: https://github.com/cncf-tags/green-reviews-tooling/blob/main/docs/proposals/proposal-003-report.md#metadata

3. Compute the sci

We can run the PromQL query which is already available using the Prometheus Go Client:

@nikimanoledaki
Copy link
Contributor

This could be done by starting a Prometheus Go client: https://github.com/prometheus/client_golang

@AntonioDiTuri AntonioDiTuri changed the title [ACTION] Proposal 3 - Collect [ACTION] Proposal 3 - Collect & Compute Dec 11, 2024
@qasmi
Copy link

qasmi commented Dec 12, 2024

I would like to work on this issue

@SRF-Audio
Copy link
Contributor

@qasmi I was going to work on part 3 of this task, so let me know if you get assigned this ticket.

Once you've got your structure in place, and then I can create a module for the storage part and fit in with your design.

@qasmi
Copy link

qasmi commented Jan 16, 2025

@SRF-Audio I will let you know. Sorry for the late response !

@AntonioDiTuri
Copy link
Contributor Author

I will assign you both and then you can sync on how to split, what do you think?

@SRF-Audio
Copy link
Contributor

Works for me!

@AntonioDiTuri
Copy link
Contributor Author

Hi guys! Any updates on this one? @qasmi @SRF-Audio
Let me know if you need support :)

@AntonioDiTuri AntonioDiTuri added the good first issue Good for newcomers label Feb 11, 2025
@locomundo locomundo moved this to Backlog in Green Reviews Feb 11, 2025
@locomundo locomundo moved this from Backlog to In progress in Green Reviews Feb 11, 2025
@nikimanoledaki nikimanoledaki moved this from In progress to Ready in Green Reviews Feb 12, 2025
@dipankardas011
Copy link
Contributor

I can take on this issue

@nikimanoledaki nikimanoledaki moved this from Ready to In progress in Green Reviews Feb 12, 2025
@nikimanoledaki
Copy link
Contributor

Hey folks! We split this into three issues:

@dipankardas011 will work on the first one that also sets up the Go application with the client that fetches metrics from the Prometheus HTTP API.

After that initial setup of the Go client is done, we should be able to work on fetching the 3 sets of metrics separately. You are welcome to follow up on #60 and #61. Thank you for your time and willingness to contribute to the project! :)

@nikimanoledaki nikimanoledaki added roadmap and removed good first issue Good for newcomers labels Feb 13, 2025
@nikimanoledaki nikimanoledaki added this to the KCCN Europe 2025 milestone Feb 13, 2025
@SRF-Audio
Copy link
Contributor

Hey @AntonioDiTuri sorry, last couple of weeks I was swamped. I get back from Barcelona next week, and I'll have some time to look at these.

@qasmi
Copy link

qasmi commented Mar 1, 2025

Hi, sorry for the delayed response! I've been overloaded with work lately and haven’t had a chance to look into this issue yet. I'm slowly getting back on track and should have some time to work on project soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

No branches or pull requests

5 participants