Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on classList in fabricator.js #19

Closed
tylersticka opened this issue Dec 28, 2015 · 0 comments
Closed

Don't rely on classList in fabricator.js #19

tylersticka opened this issue Dec 28, 2015 · 0 comments
Assignees

Comments

@tylersticka
Copy link
Member

classList is awesome, but it isn't fully supported in any version of IE.

For most projects I would opt for a polyfill, but I think that could be confusing given that most of our Fabricator styles and scripts strive to not litter anything global to avoid confusing what is or isn't part of the project toolkit. Something like the classlist module might be a more appropriate choice, though I'll defer to @erikjung if he feels strongly either way.

See also: #14 #18

@tylersticka tylersticka self-assigned this Dec 28, 2015
tylersticka added a commit that referenced this issue Dec 28, 2015
Implements a fallback for classList when element.classList is falsey.

Refs: #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant