Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: zt warp to warp connectivity settings #3759

Conversation

josip-stanic
Copy link
Contributor

@josip-stanic josip-stanic commented Aug 23, 2024

Adds connectivity block with icmp/icmp_proxy_enabled and warp_to_warp/offramp_warp_enabled to cloudflare_zero_trust_gateway_settings resource.

Fixes #3723
Previous stale PR #3328

Copy link
Contributor

changelog detected ✅

root_ca = true
virtual_ip = true
}
connectivity {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still has the same test failure from the previous PR that hasn't been addressed by the service team yet.

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTeamsAccounts_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTeamsAccounts_ConfigurationBasic
    resource_cloudflare_teams_accounts_test.go:23: Step 1/1 error: Error running apply: exit status 1
        
        Error: error updating Teams Account connectivity settings for account "f037e56e89293a057740de681ac9abbe": error unmarshalling the JSON response error body: invalid character '' looking for beginning of value
        
          with cloudflare_zero_trust_gateway_settings.opwxnpfurs,
          on terraform_plugin_test.tf line 12, in resource "cloudflare_zero_trust_gateway_settings" "opwxnpfurs":
          12: resource "cloudflare_zero_trust_gateway_settings" "opwxnpfurs" {
        
--- FAIL: TestAccCloudflareTeamsAccounts_ConfigurationBasic (2.39s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	3.476s
FAIL
make: *** [testacc] Error 1

Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

Copy link
Contributor

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set "Allow WARP to WARP connection" from terraform
3 participants