Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated requests to POST {helper}/tasks/{task-id}/aggregate_shares are aborted #557

Open
cjpatton opened this issue Mar 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@cjpatton
Copy link
Contributor

If we detect a batch overlap, we abort:
https://github.com/cloudflare/daphne/blob/main/daphne/src/roles/helper.rs#L199-L209

But if the batch interval hasn't changed, we're meant to handle this idempotently:
https://datatracker.ietf.org/doc/html/draft-ietf-ppm-dap-09#section-4.6.2-16

@cjpatton cjpatton added the bug Something isn't working label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant