Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListLoadBalancerPools doesn't return Pagination details to impossible to tell if you have more results to go through #1437

Open
2 tasks done
cdloh opened this issue Nov 9, 2023 · 1 comment

Comments

@cdloh
Copy link
Contributor

cdloh commented Nov 9, 2023

Confirmation

  • My issue isn't already found on the issue tracker.
  • I have replicated my issue using the latest version of the library and it is still present.

cloudflare-go version

v0.81.0

### Go environment

GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/cloh/Library/Caches/go-build"
GOENV="/Users/cloh/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/cloh/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/cloh/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/homebrew/Cellar/go/1.19.6/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/homebrew/Cellar/go/1.19.6/libexec/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.19.6"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/SNIP/backend/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/bq/drjvqxkj1xs510c4hfh3d55m0000gp/T/go-build2121482238=/tmp/go-build -gno-record-gcc-switches -fno-common"

Expected output

Either the API to auto paginate or to respond with the ResultInfo so pagination can be handled by end user.

Actual output

No idea if there is another page

Code demonstrating the issue

lbps, err := api.ListLoadBalancerPools(ctx, cloudflare.AccountIdentifier("1234"), cloudflare.ListLoadBalancerPoolParams{})

Steps to reproduce

Try to use the API

References

No response

@jacobbednarz
Copy link
Member

yes the method signature does need an update here to align with the conventions. do you want to send over a PR addressing them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants