Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you considered a common backend.go method? #23

Open
GitHub-huyuan opened this issue Nov 14, 2023 · 3 comments
Open

Have you considered a common backend.go method? #23

GitHub-huyuan opened this issue Nov 14, 2023 · 3 comments

Comments

@GitHub-huyuan
Copy link

It feels like it could be similar to etcd, which implements the ServiceBackend interface.Is there a problem?

@khash
Copy link
Member

khash commented Nov 16, 2023

Can you elaborate please?

@GitHub-huyuan
Copy link
Author

There is a backend.go file in the plugin directory that defines the ServiceBackend interface, so why don't we implement the methods in this interface? I don't know if I've made myself clear, what I'm asking is why you don't abstract into this interface form

@khash
Copy link
Member

khash commented Nov 22, 2023

I see. This plugin is a modified version of the Redis one which doesn't use the interface. Perhaps the interface is a newer abstraction that was introduced after the Redis plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants