Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# client SDK: remove use of ?connection_id query param to subscribe route #251

Open
gefjon opened this issue Feb 19, 2025 · 0 comments
Open

Comments

@gefjon
Copy link
Contributor

gefjon commented Feb 19, 2025

Currently, the SDK generates its ConnectionId locally, and passes it to the subscribe HTTP route. This is wrong; the server should (and would, given the opportunity) generate a unique ConnectionId for the connection and return it to the client. Rework the C# client SDK to that effect.

DoD: When running a C# client, the host logs do not contain any lines like:

2025-02-19T15:53:04.862398Z DEBUG /home/phoebe/clockworklabs/SpacetimeDB/crates/client-api/src/routes/subscribe.rs:74: The connection_id query parameter to the subscribe HTTP endpoint is internal and will be removed in a future version of SpacetimeDB.    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant