Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out if server-side updates are already grouped by table #232

Open
RReverser opened this issue Jan 29, 2025 · 0 comments
Open

Figure out if server-side updates are already grouped by table #232

RReverser opened this issue Jan 29, 2025 · 0 comments
Assignees

Comments

@RReverser
Copy link
Contributor

Here

// TODO: is there any guarantee that transaction update contains each table only once, aka updates are already grouped by table?
// If so, we could simplify this and other methods by moving the dictionary inside the main loop and using only the primary key as key.
var primaryKeyChanges = new Dictionary<(IRemoteTableHandle table, object primaryKeyValue), DbOp>();

and in other places we could simplify quite a bit of code if we can assume that database updates / transaction updates already have updates grouped and deduplicated by table, but it's currently not clear if it's something we can rely on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants