trait ReadColumn, to read a single column from a RowRef
#789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit defines `trait ReadColumn`, which is implemented for types that can be stored in a table column and can be read out of said table column. Its interesting method is `read_column(row: RowRef<'_>, idx: usize) -> Result<Self, TypeError>`, which attempts to read the `idx`th column of `row` as a value of type `Self`, returning a `TypeError` if the row in question does not have the appropriate types. `ReadColumn` is implemented for Rust equivalents of all non-compound `AlgebraicType`s, i.e. integers, floats, `bool` and `String`. It is also implemented for all SATS value types, including those which represent values of compound types, i.e. `AlgebraicValue`, `ProductValue`, `SumValue`, `ArrayValue` and `MapValue`.
|
Also note that I ran the
Other than that, the Miri tests passed (after about half an hour). |
kazimuth
reviewed
Feb 5, 2024
| assert_wrong_type_error::<f32>(row_ref, idx, &col_ty.algebraic_type, AlgebraicType::F32)?; | ||
| assert_wrong_type_error::<f64>(row_ref, idx, &col_ty.algebraic_type, AlgebraicType::F64)?; | ||
| assert_wrong_type_error::<bool>(row_ref, idx, &col_ty.algebraic_type, AlgebraicType::Bool)?; | ||
| assert_wrong_type_error::<String>(row_ref, idx, &col_ty.algebraic_type, AlgebraicType::String)?; |
There was a problem hiding this comment.
that's an entertaining pattern
There was a problem hiding this comment.
Can you tell I miss Common Lisp having types at runtime?
kazimuth
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This commit defines
trait ReadColumn, which is implemented for types that can be stored in a table column and can be read out of said table column.Its interesting method is
read_column(row: RowRef<'_>, idx: usize) -> Result<Self, TypeError>, which attempts to read theidxth column ofrowas a value of typeSelf, returning aTypeErrorif the row in question does not have the appropriate types.ReadColumnis implemented for Rust equivalents of all non-compoundAlgebraicTypes, i.e. integers, floats,boolandString. It is also implemented for all SATS value types, including those which represent values of compound types, i.e.AlgebraicValue,ProductValue,SumValue,ArrayValueandMapValue.Note that this commit does not use the
ReadColumninterface anywhere, except in tests. Follow-ups will useReadColumnin various places, including:API and ABI breaking changes
None.
Expected complexity level and risk
3: non-trivial uses of
unsafe; new uses of existingbflatn_fromserialization.