Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove row deduplication in incremental update #2397

Open
joshua-spacetime opened this issue Mar 7, 2025 · 1 comment
Open

Remove row deduplication in incremental update #2397

joshua-spacetime opened this issue Mar 7, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@joshua-spacetime
Copy link
Collaborator

The server deduplicates rows for incremental join updates before sending the updated rows to the client.

/// Note, the 1.0 api does allow for duplicate rows.
/// Hence this may be removed at any time after 1.0.
pub fn eval_delta<'a, Tx: Datastore + DeltaStore>(

This is a bug.

It was necessary at the time it was introduced because the client SDKs did not handle duplicate rows. The SDKs were eventually updated to handle duplicate rows, but the deduplication on the server was never removed.

This has the potential to result in a corrupted SDK client cache for join subscriptions.

@joshua-spacetime joshua-spacetime added the bug Something isn't working label Mar 7, 2025
@joshua-spacetime joshua-spacetime self-assigned this Mar 7, 2025
@joshua-spacetime
Copy link
Collaborator Author

While I don't know the exact query responsible, I believe this to be a manifestation of the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant