Clarify what is a valid module name #2386
Merged
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
coolreader18
force-pushed
the
noa/dbname-publish-docs
branch
from
a8dfa7e to
63ee182
Compare
|
This will require a corresponding spacetime-docs PR to update the docs. Can you open that? (See https://github.com/clockworklabs/spacetime-docs?tab=readme-ov-file#cli-reference-section, or just make the change manually without regenerating) |
|
Already did: clockworklabs/spacetime-docs#252 |
|
Nice! sold. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
From a conversation on the discord.
API and ABI breaking changes
None; anything new caught by this will already have been denied by the server, this just gives a better error message.
Expected complexity level and risk
1
Testing