Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HTTP POST requests to use compression #1325

Open
jdetter opened this issue Jun 3, 2024 · 2 comments
Open

Allow HTTP POST requests to use compression #1325

jdetter opened this issue Jun 3, 2024 · 2 comments

Comments

@jdetter
Copy link
Collaborator

jdetter commented Jun 3, 2024

We've recently discovered that there's a post body maximum size of 2MB. We'd like to increase this value, but there are some security implications to doing this: https://docs.rs/axum/latest/axum/extract/index.html#request-body-limits

So, another way we can allow users to invoke reducers with large parameters would be to use compression. Since these are calls over the HTTP interface and not through websockets we care less about performance so we could go with something that yields a higher compression ratio.

@Lethalchip
Copy link

Lethalchip commented Jun 12, 2024

Rate limiting calls over the HTTP API could also be a valid alternative. It would reduce the risk associated with increasing the max DefaultBodyLimit.

@P1YU5H-50N1
Copy link

I believe brotli will be a good choice for payload compression as it provides good compression ratio and processing time than other available choices. Can I contribute to this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants