You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just tried upgrading some deps, and noticed that the latest version of core.async, 1.6.673, breaks Manifold's go-off macro, which depends on some undocumented fns to reuse the same IOC machinery.
Initially, it looks like the fns were just moved around internally, but since the major change in the latest version of core.async involves dynamic loading of the go analyzer, it's possible that bigger changes are required.
I think we can just resolve what we need. But in the worst-case scenario, we either copy the relevant core.async code unmodified, which I believe the EPL allows (but IANAL), or we make go-off a separate repo under a different license.
For now, anyone using go-off should avoid upgrading to core.async 1.6.673+.
The text was updated successfully, but these errors were encountered:
KingMob
changed the title
core.async 1.6.673 breaks go-off
core.async 1.6.673 breaks go-offApr 5, 2023
Some of the functions that we were relying on to hijack the go state machine compilation changed namespaces. This updates the code to reference where they now live.
Addresses clj-commons#229
From Slack:
The text was updated successfully, but these errors were encountered: