Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core.async 1.6.673 breaks go-off #229

Closed
KingMob opened this issue Apr 5, 2023 · 1 comment
Closed

core.async 1.6.673 breaks go-off #229

KingMob opened this issue Apr 5, 2023 · 1 comment
Labels
bug Confirmed bug good first issue Suitable for beginners, either on their own, or with help

Comments

@KingMob
Copy link
Collaborator

KingMob commented Apr 5, 2023

From Slack:

I just tried upgrading some deps, and noticed that the latest version of core.async, 1.6.673, breaks Manifold's go-off macro, which depends on some undocumented fns to reuse the same IOC machinery.
Initially, it looks like the fns were just moved around internally, but since the major change in the latest version of core.async involves dynamic loading of the go analyzer, it's possible that bigger changes are required.
I think we can just resolve what we need. But in the worst-case scenario, we either copy the relevant core.async code unmodified, which I believe the EPL allows (but IANAL), or we make go-off a separate repo under a different license.
For now, anyone using go-off should avoid upgrading to core.async 1.6.673+.

@KingMob KingMob changed the title core.async 1.6.673 breaks go-off core.async 1.6.673 breaks go-off Apr 5, 2023
@KingMob
Copy link
Collaborator Author

KingMob commented Apr 5, 2023

@tanzoniteblack Are you interested in helping? Do you know of anyone at Yummly who should be pinged too/instead?

@KingMob KingMob added bug Confirmed bug good first issue Suitable for beginners, either on their own, or with help labels Apr 5, 2023
tanzoniteblack added a commit to tanzoniteblack/manifold that referenced this issue Apr 5, 2023
Some of the functions that we were relying on to hijack the go state machine compilation changed namespaces. This updates the code to reference where they now live.

Addresses clj-commons#229
@KingMob KingMob closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug good first issue Suitable for beginners, either on their own, or with help
Projects
None yet
Development

No branches or pull requests

1 participant