Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clojure 1.7 breaks Marginalia (including this plugin) #18

Open
Quezion opened this issue Sep 3, 2015 · 2 comments
Open

Clojure 1.7 breaks Marginalia (including this plugin) #18

Quezion opened this issue Sep 3, 2015 · 2 comments

Comments

@Quezion
Copy link

Quezion commented Sep 3, 2015

There was an issue with a change in arity for the LispReader functions in Clojure 1.7. This was simple fix but the current maintainer of marginalia is inactive. See clj-commons/marginalia#153

MichaelBlume has forked Marginalia and this plugin. If you want a working version hosted off Clojars, please take a look at the forked repo for updated dependency information.

I mean no offense to the current maintainers of this plugin, but I burned some time updating it myself before I realize MichaelBlume had also forked lein-marginalia (which wasn't mentioned in #153.)
@Quezion Quezion changed the title Clojure 1.7 breaks Marginalia and this plugin has not updated Clojure 1.7 breaks Marginalia and this plugin isn't updated Sep 3, 2015
@Quezion Quezion changed the title Clojure 1.7 breaks Marginalia and this plugin isn't updated Clojure 1.7 breaks Marginalia and hence this plugin Sep 3, 2015
@Quezion Quezion changed the title Clojure 1.7 breaks Marginalia and hence this plugin Clojure 1.7 breaks Marginalia including this plugin Sep 3, 2015
@Quezion Quezion changed the title Clojure 1.7 breaks Marginalia including this plugin Clojure 1.7 breaks Marginalia (including this plugin) Sep 14, 2015
@ssuehs-shango
Copy link

I ran into this as well. Does the same or similar break occur with Clojure 1.8RCn?

@metasoarous
Copy link

This should be closed I believe? Seems like 1.7 is fixed now in general (as long as you're not using reader conditionals).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@metasoarous @Quezion @ssuehs-shango