Finished k README.md

Author: clayrisser

Diff for: phaseB/README.md

@@ -9,9 +9,11 @@
 ### Create intrinsic element types
 
 ### Create elements
+
 Elements should extend the BaseElement
 
 ### Create root element from custom element
+
 The root element should be created from a custom element that logically
 sits at the top of the tree
 

Diff for: phaseD/README.md

@@ -10,6 +10,7 @@ basic concepts remain the same.
 ### Create node type
 
 ### Replace element used for root element
+
 The most critical element to get things working
 is the root element, since it is required to
 create the root fiber

Diff for: phaseG/README.md

@@ -9,6 +9,7 @@
 ### Create intrinsic element types
 
 ### Create elements
+
 Remember elements should extend the BaseElement
 
 ## Interesting Files

Diff for: phaseH/README.md

@@ -13,14 +13,14 @@ child
 
 ```tsx
 <Hello>
-  <World />
-  i will trigger a text lifecycle method
+  <World />i will trigger a text lifecycle method
 </Hello>
 ```
 
 The reconciler text lifecycle methods explicitly specifies the element to use for text
 
 #### createTextInstance
+
 ```ts
 createTextInstance(
   text: string,
@@ -34,6 +34,7 @@ createTextInstance(
 ```
 
 #### resetTextContent
+
 Because my renderer does not rerender I don't need this.
 
 This probably should be implemented in a sideeffect renderer.
@@ -45,6 +46,7 @@ resetTextContent(_instance: Instance): void {
 ```
 
 #### commitTextUpdate
+
 Because my renderer does not rerender I don't need this.
 
 This probably should be implemented in a sideeffect renderer.
@@ -60,6 +62,7 @@ commitTextUpdate(
 ```
 
 #### shouldSetTextContent
+
 This is used to determine if the fiber is a text fiber
 
 ```ts
@@ -69,6 +72,10 @@ shouldSetTextContent(_type: Type, props: Props): boolean {
 }
 ```
 
+## Interesting Files
+
+[src/reconciler.ts](src/reconciler.ts)
+
 ## Demo
 
 ```sh

Diff for: phaseI/README.md

@@ -2,7 +2,141 @@
 
 > finish reconciler bindings
 
-## Usage
+## Steps
+
+### Fill out the rest of the reconciler lifecycle methods
+
+#### getPublicInstance
+
+```ts
+getPublicInstance(instance: Instance | TextInstance): PublicInstance {
+  return instance;
+}
+```
+
+#### prepareForCommit
+
+```ts
+prepareForCommit(_containerInfo: Container): void {
+  // noop
+}
+```
+
+#### prepareUpdate
+
+```ts
+prepareUpdate(
+  _instance: Instance,
+  _type: Type,
+  _oldProps: Props,
+  _newProps: Props,
+  _rootContainerInstance: Container,
+  _hostContext: HostContext
+): null | UpdatePayload {
+  return true;
+}
+```
+
+#### resetAfterCommit
+
+```ts
+resetAfterCommit(_containerInfo: Container): void {
+  // noop
+}
+```
+
+#### finalizeInitialChildren
+
+```ts
+finalizeInitialChildren(
+  _parentInstance: Instance,
+  _type: Type,
+  _props: Props,
+  _rootContainerInstance: Container,
+  _hostContext: HostContext
+): boolean {
+  return true;
+}
+```
+
+#### commitUpdate
+
+```ts
+commitUpdate(
+  instance: Instance,
+  _updatePayload: any,
+  _type: string,
+  _oldProps: Props,
+  newProps: Props
+): void {
+  return instance.commitUpdate(newProps);
+}
+```
+
+#### commitMount
+
+```ts
+commitMount(instance: Instance, _type: Type, _newProps: Props): void {
+  instance.commitMount();
+}
+```
+
+#### shouldDeprioritizeSubtree
+
+```ts
+shouldDeprioritizeSubtree(): boolean {
+  return true;
+}
+```
+
+#### scheduleDeferredCallback
+
+```ts
+scheduleDeferredCallback(
+  callback?: () => any,
+  _options?: { timeout: number }
+): any {
+  if (callback) {
+    throw new Error(
+      'Scheduling a callback twice is excessive. Instead, keep track of ' +
+        'whether the callback has already been scheduled.'
+    );
+  }
+}
+```
+
+#### cancelDeferredCallback
+
+```ts
+cancelDeferredCallback(_callbackID: any): void {
+  // noop
+}
+```
+
+#### setTimeout
+
+```ts
+setTimeout(
+  handler: (...args: any[]) => void,
+  timeout: number
+): TimeoutHandle | NoTimeout {
+  return setTimeout(handler, timeout);
+}
+```
+
+#### clearTimeout
+
+```ts
+clearTimeout(handle: TimeoutHandle | NoTimeout): void {
+  return clearTimeout(handle);
+}
+```
+
+## Interesting Files
+
+[src/reconciler.ts](src/reconciler.ts)
+
+## Demo
 
 ```sh
 npm run start

Diff for: phaseI/src/reconciler.ts

@@ -53,7 +53,6 @@ export default ReactReconciler<
     parentInstance.appendChild(child);
   },
 
-  //
   finalizeInitialChildren(
     _parentInstance: Instance,
     _type: Type,
@@ -76,18 +75,15 @@ export default ReactReconciler<
     return label;
   },
 
-  //
   getPublicInstance(instance: Instance | TextInstance): PublicInstance {
     log.debug('getPublicInstance');
     return instance;
   },
 
-  //
   prepareForCommit(_containerInfo: Container): void {
     log.debug('prepareForCommit');
   },
 
-  //
   prepareUpdate(
     _instance: Instance,
     _type: Type,
@@ -100,7 +96,6 @@ export default ReactReconciler<
     return true;
   },
 
-  //
   resetAfterCommit(_containerInfo: Container): void {
     log.debug('resetAfterCommit');
   },
@@ -160,7 +155,6 @@ export default ReactReconciler<
     return false;
   },
 
-  // @ts-ignore
   getRootHostContext(_rootContainerInstance: Container): HostContext {
     log.debug('getRootHostContext');
     if (dev) log.warn("'getRootHostContext' not supported");
@@ -171,7 +165,6 @@ export default ReactReconciler<
     _parentHostContext: HostContext,
     _type: Type,
     _rootContainerInstance: Container
-    // @ts-ignore
   ): HostContext {
     log.debug('getChildHostContext');
     if (dev) log.warn("'getChildHostContext' not supported");
@@ -180,7 +173,6 @@ export default ReactReconciler<
 
   now: Date.now,
 
-  //
   commitUpdate(
     instance: Instance,
     _updatePayload: any,
@@ -192,19 +184,16 @@ export default ReactReconciler<
     return instance.commitUpdate(newProps);
   },
 
-  //
   commitMount(instance: Instance, _type: Type, _newProps: Props): void {
     log.debug('commitMount');
     instance.commitMount();
   },
 
-  //
   shouldDeprioritizeSubtree(): boolean {
     log.debug('shouldDeprioritizeSubtree');
     return true;
   },
 
-  //
   scheduleDeferredCallback(
     callback?: () => any,
     _options?: { timeout: number }
@@ -218,13 +207,11 @@ export default ReactReconciler<
     }
   },
 
-  //
   cancelDeferredCallback(_callbackID: any): void {
     log.debug('cancelDeferredCallback');
     // noop
   },
 
-  //
   setTimeout(
     handler: (...args: any[]) => void,
     timeout: number
@@ -233,7 +220,6 @@ export default ReactReconciler<
     return setTimeout(handler, timeout);
   },
 
-  //
   clearTimeout(handle: TimeoutHandle | NoTimeout): void {
     log.debug('clearTimeout');
     return clearTimeout(handle);