Adjust max_prepared_transactions only when it is default #7712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Argh, I always forget to check it with older PG versions. |
onurctirtir
reviewed
Mar 5, 2025
| */ | ||
| #if PG_VERSION_NUM >= PG_VERSION_16 | ||
| struct config_generic *gconf = find_option("max_prepared_transactions", |
There was a problem hiding this comment.
Two questions:
- Why do we provide "create_placeholders" as "true"?
- Should we provide "elevel" as "ERROR" maybe?
There was a problem hiding this comment.
Thank you for your comments. I no longer remember why. Right now providing "create_placeholders" as "false" and "elevel" as "ERROR" looks better to me, and it seems to work. Fixed that, rebased to main, and squashed my commits
Green-Chan
force-pushed
the
021_twophase-fix
branch
from
b7c57fe to
84903e7
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #7712 +/- ##
===========================================
- Coverage 89.17% 48.71% -40.47%
===========================================
Files 283 283
Lines 61023 60469 -554
Branches 7617 7464 -153
===========================================
- Hits 54420 29459 -24961
- Misses 4415 28375 +23960
- Partials 2188 2635 +447 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7711.
Change AdjustMaxPreparedTransactions to really check if max_prepared_transactions is explicitly set by user, and only adjust max_prepared_transactions when it is default.
This fixes 021_twophase test failure with loaded Citus library after postgres/postgres@b39c5272.