-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InputHook.cpp: control bypasses not respected #3230
Comments
I fail to see how this isn't intended logic. If nui has been given focus, the game shouldn't be reciving any of that input at all, since that has been routed to the front end, if the script wanted they game to have game input, they would have set the argument for keyboard input, to false |
The push to talk keybind(s) explicitly bypass that logic to allow using it when nui has focus - GameInput.cpp#L1368-L1388 |
That sounds incredibly stupid and not intended. |
This was completely intended. |
Yeah, that's indeed a regression. I already had this on my personal to-do since someone reported it on Discord earlier, but I haven't had the time to check it out yet. Reverting to the original behavior isn't a proper solution either, as stuck buttons on focus loss are also a bug. |
an example what is going on https://github.com/user-attachments/assets/fe762aeb-bf40-45d2-a215-2d50c363a678 |
I believe this bug was introduced in #3076 @tens0rfl0w i read this this fix was introduced to prevent shooting when nui get focused, maybe by disabling every key we can turn off only shooting button |
What happened?
When focus is stolen by NUI all the mouse buttons are reset, even if they shouldn't be. If your push to talk is bound to a mouse key and you are using it when focus is stolen PTT is turned off.
Expected result
PTT should remain enabled until the key is no longer pressed
Reproduction steps
SetNuiFocus(true, true)
)Importancy
There's a workaround
Area(s)
FiveM
Specific version(s)
FiveM 13301+
Additional information
Control bypasses are used to allow PTT to be pressed while NUI is open.
I believe this bug was introduced in #3076 @tens0rfl0w
The text was updated successfully, but these errors were encountered: