Hi, could you include a resource to easily reproduce the crash?

Hi, could you include a resource to easily reproduce the crash?

Hi due to copyright reasons and the size of such a resource (2GB+) I can hardly upload it here but feel free to DM me at Discord @DurtyFree and I am happy to provide it privately

We are a server with an average of 250-300 players.

We have exactly this problem, as addressed here by DurtyFree.

For this reason, we would also like to see improvements made here so that the problem can be resolved quickly.

Hey,
we also have this problem. Especially when players go through pieces of clothing they get the crash with the error message that DurtyFree send above.

+1

I think the same or similar was already reported years ago here https://forum.cfx.re/t/native-setpedcomponentvariation-0x262b14f48d29de80/2108253

There is repro resource attached (I believe it was for 1604 back then 😅), it was even fixed for a while but removed because it caused more issues. https://github.com/citizenfx/fivem/blob/master/code/components/gta-streaming-five/src/CrashFixes_Clothing.cpp

I was able to increase the limit to 512 without any noticiable issues while testing

I'm guessing that other fix attempt was missing patches in some other places and that's why it was causing weird crashes

I was able to increase the limit to 512 without any noticiable issues while testing

I'm guessing that other fix attempt was missing patches in some other places and that's why it was causing weird crashes

You possibly sharing this fix? I would love to testing it on a live server

Unfortunately this is not something you would be able to test on a live server.

The patch is done but it requires some other fix to prevent crashing players that don't yet have the patch.

Exact same problem.

Hoping the Cfxre team looks into and implements this

Hope this is looked into and fixed as a priority as yesterday alone in the space of 6 hours we had nearly 200 crashes with the errors reported above which isnt ideal for a server owner or players of the server

Afaik @slashkeyvalue already implemented a fix and its just waiting for some other changes to be published before being merged.

Maybe CFX team can confirm and provide more information

Another 2-300 concurrent players server here, Project NXT.
We are also fighting this issue, and stand with Alexander here (@DurtyFree).

A giant +1 from us. This is quickly becoming one of the most limiting factors in growing and increasing the quality our content to our end users.

Afaik @slashkeyvalue already implemented a fix and its just waiting for some other changes to be published before being merged.

Maybe CFX team can confirm and provide more information

I believe it usually takes 5-6 weeks or so before fixes get pushed to Release build on average? Correct me if I'm wrong @Nobelium-cfx

There has been no push or commit to fix this issue yet.

I do have a working prototype for it but haven't had the time to actually finish it and can't promise I will be able to in the near future.

Maybe someone else from Cfx manages to fix it before i do

There has been no push or commit to fix this issue yet.

I do have a working prototype for it but haven't had the time to actually finish it and can't promise I will be able to in the near future.

Maybe someone else from Cfx manages to fix it before i do

Could you share what you have achived so far?

has anyone had luck on fixing this?

has anyone had luck on fixing this?

There is no way in fixing this yourself. Will most likely have to wait until someone creates a PR to fix this as CFX doesn't seem to care about this

im getting the same issues.. i packed a girls pack and didnt do anything for their hair because why would you.. but i have made those settings so hair works with hats and im getting game crashes at random, i have optimized the hell out of this pack the best i can and the total size is 3.5gig with about 4500 files... nothing is over the 128 limit as well..

hope i can get some help on this as i have worked on these packs for weeks..

Is this still an issue? About to do a big EUP update with DurtyCloth and want to kinda plan ahead.

Is this still an issue? About to do a big EUP update with DurtyCloth and want to kinda plan ahead.

Yes it still is but DCT provides options to shrink the possibility of it occuring, with the trade off some game clothing mechanics

@DurtyFree Is there something that changed with DurtyCloth in recent updates that changed how packs were generated, even with ped alternates disabled? We returned back to our old clothing packs, removed all extra generated metadata files in our clothing packs, and we're still getting massive rates of this crash, same game build, same clothing items, only difference is the version of DurtyClothTool.

@DurtyFree Is there something that changed with DurtyCloth in recent updates that changed how packs were generated, even with ped alternates disabled? We returned back to our old clothing packs, removed all extra generated metadata files in our clothing packs, and we're still getting massive rates of this crash, same game build, same clothing items, only difference is the version of DurtyClothTool.

Try to reproduce this issue just with the cloth resource and nothing else. Because its not an issue only caused by clothes

With "ped alternates disabled" it should create as much (and in some cases even less) entries as before.

@DurtyFree Is there something that changed with DurtyCloth in recent updates that changed how packs were generated, even with ped alternates disabled? We returned back to our old clothing packs, removed all extra generated metadata files in our clothing packs, and we're still getting massive rates of this crash, same game build, same clothing items, only difference is the version of DurtyClothTool.

Try to reproduce this issue just with the cloth resource and nothing else. Because its not an issue only caused by clothes

With "ped alternates disabled" it should create as much (and in some cases even less) entries as before.

We did two separate tests today, one like you said with just clothing resources, no measured decrease in the crash rate, and then we did an update to the packs, where we added a chunk (~30 total) of standard clothing with no metadata, just plain clothing, and the crash rate increased quite a bit.

This is becoming out of control can we get a fix please Rockstar

This seriously should be higher priority.

Is this easy to solve by increasing a pool size in the gameconfig.xml or is a hardcoded size?

Edit: sorry I didnt properly read the issue.

It is unfortunate and makes buying more EUP rather pointless if we are all unable to add more with this limitation.

I see @prikolium-cfx deferred it. Suppose we will just have to wait gents. I am not going to be a downer about any future commits to the project. Because I have seen several being made still by some contributors... hopefully this gets priority as its been several months now and its such a limiting issue.

Because I have seen several being made still by some contributors... hopefully this gets priority as its been several months now and its such a limiting issue.

Do you have reproduction steps for this?

I know that getting servers to use the latest game build is a priority, based on Nobelium's work on the updated game build system, this should absolutely be a prioritized issue based on that fact alone. It's impossible to upgrade without exacerbating this issue. This crash accounts for ~57% of all crashes we experience on our server. I urge the team to reconsider the severity of this issue and the urgency of a fix.

Because I have seen several being made still by some contributors... hopefully this gets priority as its been several months now and its such a limiting issue.

Do you have reproduction steps for this?

Reproducing isn't hard, but takes a bit of work in my experience. A clothing pack with lots of hair variations (cut hair) heels as well, if I'm not mistaken. Than have a few people in the server, at the same clothing store or general area and start flicking through hats and someone will crash eventually. I am sure Durty could give more accurate steps. But from my packs and servers I have worked on, that's what triggers the crash.

Disquse fixed ped props

#2421

Now you just need someone competent enough to fix this, seeing as Disquse has parted ways.

I believe I already have a patch for this limit, but I need someone who can provide a resource to prove that this limit has been increased.

Here is a repro resource (100 hair, tested on 3095). With a male freemode ped, I can reproduce the crash using SetPedCollectionComponentVariation(PlayerPedId(),11,"mp_m_repro",0,0,0)

alternate-variations-crash.zip

I think the limit of 320 proposed in your PR might be a bit tight for some servers. Increasing it to 512, as suggested by DurtyFree, would be safer.

@DaniGP17 I am currently having this crash in my server with 225 players everyday & the crash happens very often, we believe it is our clothing pack over the prop limit on some of the props jackets/hats etc. Not sure if we can be helpful in anyway to test for you.

@DaniGP17 I am currently having this crash in my server with 225 players everyday & the crash happens very often, we believe it is our clothing pack over the prop limit on some of the props jackets/hats etc. Not sure if we can be helpful in anyway to test for you.

I already test the patch and I didn't get any crash related to that, we've to wait to a cfx member to review my PR