Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to visual indicator for sorted columns in tables #3396

Closed
3 tasks done
gabo0oo opened this issue Jan 23, 2025 · 1 comment · Fixed by #3483
Closed
3 tasks done

Changes to visual indicator for sorted columns in tables #3396

gabo0oo opened this issue Jan 23, 2025 · 1 comment · Fixed by #3483
Assignees
@rachidatecs
Labels
carryover Carryover from a previous sprint dev issue is for the dev team

Comments

@gabo0oo
Copy link
Contributor

gabo0oo commented Jan 23, 2025 •
edited by rachidatecs
Loading

Issue description

Our visual indicator for sorted columns in our tables doesn't quite match other branding across the registrar and is visually very heavy. It is required to have a visual indicator on a sorted column. These changes introduce a new style for that indicator.

Acceptance criteria

  • (1) Update visual indicator on table header to match Figma design and annotation
  • Change color fill that applies to the column temporarily on clicking sort to #F5F8FA instead of #7AB9D5
  • make the above changes to every sorted table (or and non org model)

Additional context

No response

Links to other issues

🔄 Members review #3280
@gabo0oo gabo0oo added the dev issue is for the dev team label Jan 23, 2025
@gabo0oo gabo0oo mentioned this issue Jan 24, 2025
Closed
4 tasks
@allly-b allly-b moved this from 👶 New to ⚙ Dev Parking Lot in .gov Product Board Jan 24, 2025
@allly-b
Copy link
Contributor

allly-b commented Jan 28, 2025

@gabydisarli Isn't the USWDS standard to fill the column in a different color? The figma looks like the color gets fully removed, not just changing the indicator on the header.

@gabo0oo gabo0oo changed the title Changes to visual indicator for sorted columns in tables Changes to visual indicator for sorted columns + padding changes in tables Jan 29, 2025
@gabo0oo gabo0oo changed the title Changes to visual indicator for sorted columns + padding changes in tables Changes to visual indicator for sorted columns in tables Jan 29, 2025
@gabo0oo gabo0oo mentioned this issue Jan 29, 2025
Closed
@allly-b allly-b moved this from ⚙ Dev Parking Lot to 🎯 Ready in .gov Product Board Jan 30, 2025
@rachidatecs rachidatecs self-assigned this Feb 6, 2025
@PaulKuykendall PaulKuykendall moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Feb 6, 2025
@rachidatecs rachidatecs moved this from 🔖 Planned to 🏗 In progress in .gov Product Board Feb 6, 2025
@rachidatecs rachidatecs mentioned this issue Feb 7, 2025
Merged
32 tasks
@gabo0oo gabo0oo added the skipped design Design artifact(s) will need to be updated label Feb 7, 2025
@MzBowieFan77 MzBowieFan77 moved this from 🏗 In progress to 👀 In review in .gov Product Board Feb 10, 2025
@MzBowieFan77 MzBowieFan77 added the carryover Carryover from a previous sprint label Feb 19, 2025
rachidatecs added a commit that referenced this issue Feb 19, 2025
@rachidatecs
Merge pull request #3483 from cisagov/rjm/3396-sort-ui
e52f6f3 
#3396: Redesign sort header UI - [RJM]
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Feb 19, 2025
@witha-c witha-c mentioned this issue Feb 28, 2025
Open
2 tasks
@witha-c witha-c removed the skipped design Design artifact(s) will need to be updated label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rachidatecs rachidatecs

Labels
carryover Carryover from a previous sprint dev issue is for the dev team
Projects
.gov Product Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3396: Redesign sort header UI - [RJM] cisagov/manage.get.gov
5 participants
@rachidatecs @gabo0oo @allly-b @witha-c @MzBowieFan77