Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Patterns and Textures to Bar Graphs #3146

Closed
8 tasks done
SamiyahKey opened this issue Nov 26, 2024 · 3 comments · Fixed by #3474
Closed
8 tasks done

Add Patterns and Textures to Bar Graphs #3146

SamiyahKey opened this issue Nov 26, 2024 · 3 comments · Fixed by #3474
Assignees
Labels
accessibility pertains to Section 508 compliance or other accessibility needs 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant compliance indicates that the issue is required to satisfy a necessary compliance req dev issue is for the dev team story User stories

Comments

@SamiyahKey
Copy link

SamiyahKey commented Nov 26, 2024

Story

As a with visual impairments or color vision deficiencies,
I need bar graphs to include patterns or textures in addition to color to differentiate data points,
so that I can accurately interpret the data being presented without relying on color alone.

https://getgov-staging.app.cloud.gov/admin/analytics/#content-start

Acceptance Criteria

  • Add patterns, textures, or other non-color indicators to the bar graphs to differentiate data points.
  • Ensure the patterns/textures are distinct and easily perceivable by users with visual impairments.
  • Verify that the visual updates maintain the readability and aesthetic appeal of the graphs.
  • Update the map/legend to reflect the updated colors and patterns/textures to their respective data points.
  • Ensure the updated graph is functional across different browsers and screen reader software.
  • Implement and test the graph's accessibility updates to comply with WCAG 1.4.1 Use of Color.
  • Ensure the updates work consistently across light and dark modes (if applicable).
  • Partner with UX Design team member to review and adhere to design standards.

Additional Context

Issue Links

Implementation notes:

@zandercymatics did some research and found an add-on for the JS charting library we're using (link). Alternatively, consider using a sprite and CSS background.

@SamiyahKey SamiyahKey added compliance indicates that the issue is required to satisfy a necessary compliance req design issue is for the design team story User stories labels Nov 26, 2024
@SamiyahKey SamiyahKey self-assigned this Nov 26, 2024
@SamiyahKey SamiyahKey added accessibility pertains to Section 508 compliance or other accessibility needs dev issue is for the dev team skipped design Design artifact(s) will need to be updated and removed design issue is for the design team labels Nov 26, 2024
@SamiyahKey SamiyahKey removed their assignment Dec 3, 2024
@katypies
Copy link
Contributor

@SamiyahKey it seems like this should probably be a design ticket first to determine the patterns, textures or other non-color indicators that dev should implement.

Are the items in Additional Context actually acceptance criteria? They read like additional requirements, but it's not clear to me.

@SamiyahKey
Copy link
Author

@katypies I was thinking the same thing until I discussed it with @Katherine-Osos. Because the Django admin is pretty limited with design options, this would skip design, and dev should partner with design (me) to use what's available in the most effective and accessible way possible.

In terms of the Additional Context, I attempted to point out that the legend should be updated to reflect the new colors/patterns chosen. I changed them to requirements! Thanks for that catch.

@zandercymatics
Copy link
Contributor

Note: There is a chart.js library aimed at adding this exact thing, with the purpose of resolving color blindness issues. Might be worth looking at

@zandercymatics zandercymatics added 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant and removed 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant labels Jan 29, 2025
@zandercymatics zandercymatics self-assigned this Feb 5, 2025
@PaulKuykendall PaulKuykendall moved this from 👶 New to 🏗 In progress in .gov Product Board Feb 6, 2025
@zandercymatics zandercymatics moved this from 🏗 In progress to 👀 In review in .gov Product Board Feb 6, 2025
zandercymatics added a commit that referenced this issue Feb 12, 2025
#3146: Django admin analytics page - add patterns to our bar graphs for colorblind users - [ZA]
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Feb 12, 2025
@Katherine-MN Katherine-MN removed the skipped design Design artifact(s) will need to be updated label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility pertains to Section 508 compliance or other accessibility needs 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant compliance indicates that the issue is required to satisfy a necessary compliance req dev issue is for the dev team story User stories
Projects
Status: ✅ Done
4 participants