Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "roles" column in the Portfolio "members" table in django admin #3390

Closed
1 of 2 tasks
allly-b opened this issue Jan 22, 2025 · 0 comments · Fixed by #3471
Closed
1 of 2 tasks

Remove "roles" column in the Portfolio "members" table in django admin #3390

allly-b opened this issue Jan 22, 2025 · 0 comments · Fixed by #3471
Assignees
@CocoByte
Labels
dev issue is for the dev team Feature: 🏢 Org Model quick fix
Milestone
Org Model m5 - Ma...

Comments

@allly-b
Copy link
Contributor

allly-b commented Jan 22, 2025 •
edited by CocoByte
Loading

Issue description

Right now on the portfolio page in django admin, we show the users in the portfolio with admins in one section and members in a section below. The member section has a role column, however, we are changing permissions and how we communicate them to users so the roles we currently display on admin are no longer applicable. We also are not going to prioritize determining replacement human readable phrases anytime soon. We should just remove the code and column as it no longer applies. (we can always look in git commit history if we want to see the code again)

Acceptance criteria

  • remove the roles column from the django admin portfolio members table
  • delete the unused code and make appropriate changes to clean up this area

Additional context

No response

Links to other issues

No response
@allly-b allly-b added the dev issue is for the dev team label Jan 22, 2025
@allly-b allly-b moved this from 👶 New to ⚙ Dev Parking Lot in .gov Product Board Jan 22, 2025
@allly-b allly-b moved this from ⚙ Dev Parking Lot to 🎯 Ready in .gov Product Board Jan 23, 2025
@CocoByte CocoByte self-assigned this Feb 4, 2025
@CocoByte CocoByte moved this from 🎯 Ready to 🏗 In progress in .gov Product Board Feb 5, 2025
@CocoByte CocoByte mentioned this issue Feb 6, 2025
Merged
32 tasks
@CocoByte CocoByte moved this from 🏗 In progress to 👀 In review in .gov Product Board Feb 6, 2025
CocoByte added a commit that referenced this issue Feb 18, 2025
@CocoByte
Merge pull request #3471 from cisagov/nl/3390-remove-portfolio-member…
90946f4 
…-roles-column

#3390 - Remove "roles" column in the Portfolio "members" admin table - [CB]
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CocoByte CocoByte

Labels
dev issue is for the dev team Feature: 🏢 Org Model quick fix
Projects
.gov Product Board
Status: ✅ Done
Milestone
Org Model m5 - Manage org users & the...
Development

Successfully merging a pull request may close this issue.

#3390 - Remove "roles" column in the Portfolio "members" admin table - [CB] cisagov/manage.get.gov
2 participants
@CocoByte @allly-b