[fxbug.dev] Migrate bug numbers

This changes fxbug.dev/ URLs from Monorail bug numbers to the new
Fuchsia Issue Tracker numbers.

The migration to the new issue tracker was announced here:
https://groups.google.com/a/fuchsia.dev/g/announce/c/GOYfJozEqmk/m/qsGsaJ7UAAAJ

Bug: 298074672
Change-Id: I5f4b7a26a3f41bf539fa79d15e1a108ea35a5b29
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5246697
Commit-Queue: Mark Mentovai <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>

Author: Mitchell Kember

BUILD.gn

@@ -39,7 +39,8 @@ if (crashpad_is_in_chromium || crashpad_is_in_fuchsia) {
     if (crashpad_is_in_fuchsia) {
       # TODO(fuchsia:46559): Fix the leaks and remove this.
       deps += [ "//build/config/sanitizers:suppress-lsan.DO-NOT-USE-THIS" ]
-      # TODO(fxbug.dev/108368): Remove this once the underlying issue is addressed.
+      # TODO(fxbug.dev/42059784): Remove this once the underlying issue is
+      # addressed.
       exclude_toolchain_tags = [ "hwasan" ]
     }
     if (crashpad_is_android) {

build/crashpad_buildconfig.gni

@@ -106,7 +106,7 @@ template("crashpad_executable") {
     if (crashpad_is_in_fuchsia) {
       conversion_config = [ "//build/config:Wno-conversion" ]
       if (configs + conversion_config - conversion_config == configs) {
-        # TODO(https://fxbug.dev/58162): Decide if these are worth enabling.
+        # TODO(https://fxbug.dev/42136089): Decide if these are worth enabling.
         configs += conversion_config
       }
     }
@@ -132,7 +132,7 @@ template("crashpad_loadable_module") {
     if (crashpad_is_in_fuchsia) {
       conversion_config = [ "//build/config:Wno-conversion" ]
       if (configs + conversion_config - conversion_config == configs) {
-        # TODO(https://fxbug.dev/58162): Decide if these are worth enabling.
+        # TODO(https://fxbug.dev/42136089): Decide if these are worth enabling.
         configs += conversion_config
       }
     }
@@ -158,7 +158,7 @@ template("crashpad_static_library") {
     if (crashpad_is_in_fuchsia) {
       conversion_config = [ "//build/config:Wno-conversion" ]
       if (configs + conversion_config - conversion_config == configs) {
-        # TODO(https://fxbug.dev/58162): Decide if these are worth enabling.
+        # TODO(https://fxbug.dev/42136089): Decide if these are worth enabling.
         configs += conversion_config
       }
     }

snapshot/BUILD.gn

@@ -507,7 +507,8 @@ crashpad_loadable_module("crashpad_snapshot_test_module") {
     "../client",
   ]
   if (crashpad_is_in_fuchsia) {
-    # TODO(fxbug.dev/108368): Remove this once the underlying issue is addressed.
+    # TODO(fxbug.dev/42059784): Remove this once the underlying issue is
+    # addressed.
     exclude_toolchain_tags = [ "hwasan" ]
   }
 }
@@ -526,7 +527,8 @@ crashpad_loadable_module("crashpad_snapshot_test_module_large") {
   deps += [ "$mini_chromium_source_parent:base" ]
 
   if (crashpad_is_in_fuchsia) {
-    # TODO(fxbug.dev/108368): Remove this once the underlying issue is addressed.
+    # TODO(fxbug.dev/42059784): Remove this once the underlying issue is
+    # addressed.
     exclude_toolchain_tags = [ "hwasan" ]
   }
 }
@@ -545,7 +547,8 @@ crashpad_loadable_module("crashpad_snapshot_test_module_small") {
   deps += [ "$mini_chromium_source_parent:base" ]
 
   if (crashpad_is_in_fuchsia) {
-    # TODO(fxbug.dev/108368): Remove this once the underlying issue is addressed.
+    # TODO(fxbug.dev/42059784): Remove this once the underlying issue is
+    # addressed.
     exclude_toolchain_tags = [ "hwasan" ]
   }
 }
@@ -560,7 +563,8 @@ if ((crashpad_is_linux || crashpad_is_android || crashpad_is_fuchsia) &&
     ldflags = [ "-Wl,--hash-style=both" ]
 
     if (crashpad_is_in_fuchsia) {
-      # TODO(fxbug.dev/108368): Remove this once the underlying issue is addressed.
+      # TODO(fxbug.dev/42059784): Remove this once the underlying issue is
+      # addressed.
       exclude_toolchain_tags = [ "hwasan" ]
     }
   }

snapshot/fuchsia/exception_snapshot_fuchsia.cc

@@ -74,7 +74,7 @@ bool ExceptionSnapshotFuchsia::Initialize(
 #if defined(ARCH_CPU_X86_64)
   context_.architecture = kCPUArchitectureX86_64;
   context_.x86_64 = &context_arch_;
-  // TODO(fxbug.dev/5496): Add vector context.
+  // TODO(fxbug.dev/42132536): Add vector context.
   InitializeCPUContextX86_64(
       t->general_registers, t->fp_registers, context_.x86_64);
 #elif defined(ARCH_CPU_ARM64)

snapshot/fuchsia/process_reader_fuchsia.cc

@@ -47,12 +47,12 @@ void GetStackRegions(
 #error Port
 #endif
 
-  // TODO(fxbug.dev/74897): make this work for stack overflows, e.g., by looking
-  // up using the initial stack pointer (sp) when the thread was created. Right
-  // now, it gets the stack by getting the mapping that contains the current sp.
-  // But in the case of stack overflows, the current sp is by definition outside
-  // of the stack so the mapping returned is not the stack and fails the type
-  // check, at least on arm64.
+  // TODO(fxbug.dev/42154629): make this work for stack overflows, e.g., by
+  // looking up using the initial stack pointer (sp) when the thread was
+  // created. Right now, it gets the stack by getting the mapping that contains
+  // the current sp. But in the case of stack overflows, the current sp is by
+  // definition outside of the stack so the mapping returned is not the stack
+  // and fails the type check, at least on arm64.
   zx_info_maps_t range_with_sp;
   if (!memory_map.FindMappingForAddress(sp, &range_with_sp)) {
     LOG(ERROR) << "stack pointer not found in mapping";
@@ -235,8 +235,8 @@ void ProcessReaderFuchsia::InitializeModules() {
     // Crashpad needs to use the same module name at run time for symbol
     // resolution to work properly.
     //
-    // TODO: https://fxbug.dev/6057 - once Crashpad switches to elf-search, the
-    // following overwrites won't be necessary as only shared libraries will
+    // TODO: https://fxbug.dev/42138764 - once Crashpad switches to elf-search,
+    // the following overwrites won't be necessary as only shared libraries will
     // have a soname at runtime, just like at build time.
     //
     // * For shared libraries, the soname is used as module name at build time,

snapshot/fuchsia/system_snapshot_fuchsia.cc

@@ -75,7 +75,7 @@ uint32_t SystemSnapshotFuchsia::CPURevision() const {
 #if defined(ARCH_CPU_X86_64)
   return cpuid_.Revision();
 #else
-  // TODO: https://fxbug.dev/5561 - Read actual revision.
+  // TODO: https://fxbug.dev/42133257 - Read actual revision.
   return 0;
 #endif
 }
@@ -90,7 +90,7 @@ std::string SystemSnapshotFuchsia::CPUVendor() const {
 #if defined(ARCH_CPU_X86_64)
   return cpuid_.Vendor();
 #else
-  // TODO: https://fxbug.dev/5561 - Read actual vendor.
+  // TODO: https://fxbug.dev/42133257 - Read actual vendor.
   return std::string();
 #endif
 }
@@ -193,7 +193,7 @@ bool SystemSnapshotFuchsia::NXEnabled() const {
 #if defined(ARCH_CPU_X86_64)
   return cpuid_.NXEnabled();
 #else
-  // TODO: https://fxbug.dev/5561 - Read actual NX bit value.
+  // TODO: https://fxbug.dev/42133257 - Read actual NX bit value.
   return false;
 #endif
 }

snapshot/fuchsia/thread_snapshot_fuchsia.cc

@@ -40,7 +40,7 @@ bool ThreadSnapshotFuchsia::Initialize(
 #if defined(ARCH_CPU_X86_64)
   context_.architecture = kCPUArchitectureX86_64;
   context_.x86_64 = &context_arch_;
-  // TODO(fxbug.dev/5496): Add vector context.
+  // TODO(fxbug.dev/42132536): Add vector context.
   InitializeCPUContextX86_64(
       thread.general_registers, thread.fp_registers, context_.x86_64);
 #elif defined(ARCH_CPU_ARM64)