Unable to create cookies with session=false

[divinity76]

The following code:

<?php

declare(strict_types=1);
error_reporting(E_ALL);
ini_set('display_errors', '1');
set_error_handler(
    function (int $errno, string $errstr, string $errfile, int $errline) {
        if (error_reporting() & $errno) {
            throw new \ErrorException($errstr, 0, $errno, $errfile, $errline);
        }
    }
);
require_once 'vendor/autoload.php';
$factory = new \HeadlessChromium\BrowserFactory();
$browser = $factory->createBrowser(array(
    'customFlags' => [
        '--no-sandbox',
        '--disable-gpu-sandbox',
        '--disable-setuid-sandbox',
        '--disable-dev-shm-usage',
        '--disable-breakpad',
        '--disable-crash-reporter',
        '--no-crashpad',
    ],
));
$page = $browser->createPage();
$page->setCookies([
    \HeadlessChromium\Cookies\Cookie::create("session_false", "session_false", ["session" => false, "domain" => "example.com"]),
    \HeadlessChromium\Cookies\Cookie::create("session_true", "session_true", ["session" => true, "domain" => "example.com"]),
])->await();
$cookies = $page->getAllCookies();
foreach ($cookies as $cookie) {
    var_dump($cookie->getName(), $cookie->offsetGet("session"));
}

produce this output:

string(13) "session_false"
bool(true)
string(12) "session_true"
bool(true)

but I expected this output instead:

string(13) "session_false"
bool(false)
string(12) "session_true"
bool(true)

[divinity76]

Turns out you can't directly set session=false, but session will be set to false if the cookie has an expiration date, meaning if the code is changed to

$page->setCookies([
    \HeadlessChromium\Cookies\Cookie::create("session_false", "session_false", ["expires" => PHP_INT_MAX, "domain" => "example.com"]),
    \HeadlessChromium\Cookies\Cookie::create("session_true", "session_true", ["session" => true, "domain" => "example.com"]),
])->await();

it will print the expected

string(13) "session_false"
bool(false)
string(12) "session_true"
bool(true)

🤔 not a chrome-php bug at least, this is how the DevTools protocol is designed.

We could make a convenience wrapper tho

[GrahamCampbell]

Will be supported in 1.13.