Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashtags are removed from tweet #32

Open
owennw opened this issue Feb 1, 2016 · 2 comments
Open

Hashtags are removed from tweet #32

owennw opened this issue Feb 1, 2016 · 2 comments
Labels

Comments

@owennw
Copy link
Contributor

owennw commented Feb 1, 2016

Even inadvertent ones:

(rn(0,6)).a({rx:9,ry:2,cx:(d,i)=>2_i+150_s(t/4e2)}).y({fill:d=>'#'+String.fromCharCode(70-d)+'13',stroke:'#C13'}) https://t.d3fc.io

The stroke code is not parsed on the website.

@owennw
Copy link
Contributor Author

owennw commented Feb 1, 2016

Should note that this works in the playground, so is most likely just a parsing error.

@chrisprice
Copy link
Owner

The implementation currently strips everything which Twitter defines as an entity and then attempts to parse the result using babel. If this is successful it makes it on to the site.

The entity stripping is done as an easy and reliable way of removing any leading or trailing @mentions, #hashtags or other URLs.

Currently the only way around this would be to split the string after the # e.g. stroke:'#'+'c13'.

I don't think I'm going to change the behaviour because it's an easy rule to understand. However, it is annoying that the playground doesn't also implement this functionality. Not sure of a good way of copying the behaviour though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants