Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with nbconvert 6 #10

Closed
Cadair opened this issue Sep 10, 2020 · 2 comments · Fixed by #20
Closed

Incompatibility with nbconvert 6 #10

Cadair opened this issue Sep 10, 2020 · 2 comments · Fixed by #20

Comments

@Cadair
Copy link

Cadair commented Sep 10, 2020

When running with nbconvert 6 installed, I get

AttributeError: 'ExecuteCoveragePreprocessor' object has no attribute 'setup_preprocessor'

irrespective of the value of the coverage setting.
@AdamGleave AdamGleave mentioned this issue Sep 16, 2020
Closed
@chrisjsewell
Copy link
Owner

Yeh should look to move to https://github.com/jupyter/nbclient
Also jupyter/nbclient#79 may be useful

marscher added a commit to marscher/pytest-notebook-feedstock that referenced this issue Mar 3, 2021
@marscher
pin nbformat to <6, because it is incompatible
4deeb75 
xref: chrisjsewell/pytest-notebook#10
@marscher marscher mentioned this issue Mar 3, 2021
Merged
5 tasks
@qci-amos qci-amos mentioned this issue Aug 19, 2021
Closed
@chrisjsewell chrisjsewell mentioned this issue Jan 17, 2022
Merged
@chrisjsewell
Copy link
Owner

Now fixed in pytest-notebook 0.7.0 (nbconvert is no longer a dependency)

@mhvwerts mhvwerts mentioned this issue Aug 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🔀 Merge: Update package chrisjsewell/pytest-notebook
2 participants
@Cadair @chrisjsewell