Skip to content

Commit 978d53c

Browse files
committed
autocomplete test: Add extra pump in new test for new RawAutocomplete delay
Same reasoning as in 0bfa79d. This new test was merged in zulip#1266 / 4942f25. At the time, the breaking change in upstream's RawAutocomplete had been reverted, because it broke some Google tests: flutter/flutter#161666 and it had not yet relanded, which is why our CI passed. But the reland happened, in flutter/flutter#161695 , so our test broke; this fixes it.
1 parent efcf201 commit 978d53c

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

test/widgets/autocomplete_test.dart

+4
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,10 @@ void main() {
330330
text: 'some',
331331
selection: TextSelection(baseOffset: 1, extentOffset: 3)));
332332
await tester.pump();
333+
// Add an extra pump to account for any potential frame delays introduced
334+
// by the post frame callback in RawAutocomplete's implementation.
335+
await tester.pump();
336+
333337
check(controller.value)
334338
..text.equals('some')
335339
..selection.equals(

0 commit comments

Comments
 (0)