Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializer template npm init sitefox-nbb server fails with install-traceback-emailer missing #44

Open
jasalt opened this issue Feb 21, 2025 · 1 comment

Comments

@jasalt
Copy link

jasalt commented Feb 21, 2025

  • Sitefox version c615c0a
  • nodejs version: v18.19.0 (Debian 12)
  • npm version: 10.4.0

npm init sitefox-nbb server initializer script fails after installing packages:

$ npm run serve

> [email protected] serve
> DEV=1 nbb --classpath ${VIRTUAL_ENV:=.}/node_modules/sitefox/src/ server.cljs

----- Error --------------------------------------
Message:  install-traceback-emailer does not exist
install-traceback-emailer does not exist

Starts working (without the traceback emailer) after commenting sitefox.tracebacks include and usage from server.cljs:

(ns webserver
  (:require
    ["fs" :as fs]
    [promesa.core :as p]
    [nbb.core :refer [*file*]]
    ["browser-sync" :as browser-sync]
    ["fast-glob$default" :as fg]
    [sitefox.web :as web]
    [sitefox.util :refer [env]]
    [sitefox.html :refer [render-into]]
    [sitefox.reloader :refer [nbb-reloader]]
    ;;[sitefox.tracebacks :refer [install-traceback-emailer]]
    ))

;; (when-let [admin-email (env "ADMIN_EMAIL")]
;;   (install-traceback-emailer admin-email))

(def template (fs/readFileSync "public/index.html"))
...
@chr15m
Copy link
Owner

chr15m commented Feb 21, 2025

Thanks for filing this and #43. It's strange because the end-to-end tests run by CI actually runs this server and it doesn't show this error. Looking at it now maybe it's because npm i is run at the top level in sitefox itself. I'll dig in and figure this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants