Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images are not being built #102

Open
haxorof opened this issue Jan 8, 2022 · 7 comments
Open

Docker images are not being built #102

haxorof opened this issue Jan 8, 2022 · 7 comments
Assignees

Comments

@haxorof
Copy link
Contributor

haxorof commented Jan 8, 2022

Seems Docker images are not being built when commit is done on master. Last time it worked was 5 months ago.

@bruth Can you check why it is not built anymore?

@bruth
Copy link
Contributor

bruth commented Jan 9, 2022

@haxorof Appears automated builds on Docker Hub now require a paid account.

@haxorof
Copy link
Contributor Author

haxorof commented Jan 9, 2022

Aha, I saw it too now when I looked at my own Docker hub account.

If you would specify the following secrets in the repository settings then it would be possible to build and push via Github Actions. This is what I do in my own repositories since it gives me a bit more control of when to push etc:

  • DOCKERHUB_TOKEN
  • DOCKERHUB_USERNAME
  • DOCKERHUB_PASSWORD

It would then be possible for me to for example add the following in the Github CI and also allow it to push:

      - name: Login to DockerHub
        uses: docker/[email protected]
        with:
          username: ${{ secrets.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_TOKEN }}

And for updating the description on Docker Hub:

      - name: Docker Hub Description
        uses: peter-evans/[email protected]
        with:
          username: ${{ secrets.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_PASSWORD }}
          repository: dbhi/prometheus-sql

What do you think @bruth ?

@bruth
Copy link
Contributor

bruth commented Jan 9, 2022

Updating the description would require my actual password? That seems odd, no? Can I simply use the same token? If not, can we opt to not automate updating the description since releases don't happen that often?

As a side note, it is obnoxious that Docker Hub only allows for one access token without a paid account 🙄 It does not appear that I can create organization tokens either.

@haxorof
Copy link
Contributor Author

haxorof commented Jan 9, 2022

Updating the description would require my actual password? That seems odd, no? Can I simply use the same token? If not, can we opt to not automate updating the description since releases don't happen that often?

Unfortunately it seems that the Docker Hub API does not allow token to be used for updating the description. 🙄 As you say, we can skip the automated update of the description since it is not updated that often.

As a side note, it is obnoxious that Docker Hub only allows for one access token without a paid account 🙄 It does not appear that I can create organization tokens either.

Seems that Docker trying hard to get people to pay these days. Also Docker Desktop they start to charge for if you would use it in an organization.

So what are the options now to get images published?

@bruth
Copy link
Contributor

bruth commented Jan 9, 2022

Seems that Docker trying hard to get people to pay these days. Also Docker Desktop they start to charge for if you would use it in an organization.

Indeed. To be clear, I understand and support the hard decisions they had to make for a viable business model.. but my org doesn't really use Docker Hub much other than a couple open source projects. We host internal registries. We are also a non-profit and after talking with sales, we are not required to pay for a subscription.

As I wrote that, I decided to upgrade myself to the Pro account so I can create more access tokens. However, the permission scope is pretty bad. If I provide a token, the permissions apply to all repos I have access to.

I also saw this which is laughable for small open source projects. We need a service account, but it doesn't seem like its an option for open source.

So what are the options now to get images published?

Need to think more.

@haxorof
Copy link
Contributor Author

haxorof commented Jan 9, 2022

I understand, no worries.

Omg! the prices there for service accounts are indeed something which is not viable for small open source projects.

@SamMousa
Copy link

What about pushing the images to ghcr.io? That's free for OS and integrates very cleanly with CI since it's part of the github eco system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants