Remove the no7ip build steps from overall Chocolatey CLI build process
#3591
Assignees
Labels
4 - Done
BuildAutomation
NO RELEASE NOTES
Should not be included in the release notes - not enhancing or fixing end product.
Milestone
Comments
gep13
added
0 - Backlog
BuildAutomation
Breaking Change
and removed
Breaking Change
labels
|
@vexx32 @AdmiringWorm @pauby do we agree that this is technically a breaking change, and it should wait until the next major release of Chocolatey CLI? |
|
In terms of versioning, then no. I would not consider this a breaking change. But we definitely would need to notify those affected by us not providing no7zip builds anymore before the next release of CLI. |
gep13
added a commit
to gep13/choco
that referenced
this issue
Jan 28, 2025
This commit removes the no longer required no7zip build tasks, and also the associated sln and csproj entries. Previously, it was necessary to build a version of choco.exe that didn't include the 7zip binaries, however, this version of Chocolatey CLI is no longer required. To simplify the overall build process, and also the release steps required, the decision was taken to completely remove the no7zip build.
gep13
added
the
NO RELEASE NOTES
|
@AdmiringWorm thank you for confirming. This was my thought on it as well. I have assigned this issue to the 2.5.0 milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Is Your Feature Request Related To A Problem? Please describe.
While this is no longer a problem, there was an issue related to this, which was fixed in a previous release.
There is no longer a requirement for a version of Chocolatey CLI that doesn't contain the 7zip assemblies, and as such, we can simplify our overall build process by removing the tasks related to creating it.
Describe The Solution. Why is it needed?
ReleaseOfficialNo7zipbuild configuration should be removed from the *.sln fileReleaseOfficialNo7zipbuild configuration should be removed from all *.csproj filesno7zipshould be removed from the recipe.cake file, as the collection of files specifiically for the no7zip build will no longer be requiredPrepare-ChocolateyNo7zip-Package,Build-ChocolateyNo7zip, andCreate-ChocolateyNo7zip-Packagetasks should be removed from the recipe.cake fileAdditional Context
None
Related Issues
This is a follow up to this issue:
no7zipbuild step is ILmerging all the test assemblies into the final choco.exe #3534The text was updated successfully, but these errors were encountered: